From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Christoph Hellwig <hch@lst.de>,
Chaitanya Kulkarni <kch@nvidia.com>,
linux-nvme@lists.infradead.org, Amit.Engel@Dell.com,
kbusch@kernel.org
Subject: Re: [PATCH] nvme: print disposition on err req completion
Date: Thu, 8 Jun 2023 07:53:20 +0200 [thread overview]
Message-ID: <20230608055320.GA11784@lst.de> (raw)
In-Reply-To: <a8f3f9eb-7267-219e-f6cc-f36c0ca56080@grimberg.me>
On Wed, Jun 07, 2023 at 06:08:16PM +0300, Sagi Grimberg wrote:
>> Hmm, not sure this is the right way to approach it. I'd rather
>> redo how the trace points work by having a class and the ondividual
>> tracepoints in nvme_end_req/nvme_retry_req/nvme_failover_req.
>
> :)
>
> This was the original proposal (posted as a question to the list),
> and I proposed this approach. You don't like it?
1) the different dispostitions are really very different events,
lumping them up does make tracing harder because you need to
manually filter every time
2) I really don't like exposing the disposition enum outside of core.c
next prev parent reply other threads:[~2023-06-08 5:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 6:49 [PATCH] nvme: print disposition on err req completion Chaitanya Kulkarni
2023-06-05 22:32 ` Sagi Grimberg
2023-06-07 5:00 ` Christoph Hellwig
2023-06-07 15:08 ` Sagi Grimberg
2023-06-07 17:06 ` Engel, Amit
2023-06-07 23:31 ` Chaitanya Kulkarni
2023-06-08 5:53 ` Christoph Hellwig [this message]
2023-06-08 7:02 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230608055320.GA11784@lst.de \
--to=hch@lst.de \
--cc=Amit.Engel@Dell.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).