From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: linux-nvme@lists.infradead.org, Keith Busch <kbusch@kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] nvme-mpath: fix I/O failure with EAGAIN when failing over I/O
Date: Tue, 20 Jun 2023 06:28:30 +0200 [thread overview]
Message-ID: <20230620042830.GA10371@lst.de> (raw)
In-Reply-To: <20230619141036.1051673-1-sagi@grimberg.me>
> +++ b/drivers/nvme/host/multipath.c
> @@ -102,6 +102,7 @@ void nvme_failover_req(struct request *req)
> spin_lock_irqsave(&ns->head->requeue_lock, flags);
> for (bio = req->bio; bio; bio = bio->bi_next) {
> bio_set_dev(bio, ns->head->disk->part0);
> + bio->bi_opf &= ~REQ_NOWAIT;
Please add a comment based on your explanation in the commit log here.
next prev parent reply other threads:[~2023-06-20 4:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-19 14:10 [PATCH] nvme-mpath: fix I/O failure with EAGAIN when failing over I/O Sagi Grimberg
2023-06-20 4:28 ` Christoph Hellwig [this message]
2023-06-20 10:00 ` Sagi Grimberg
2023-06-20 9:15 ` Martin Wilck
2023-06-20 9:59 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230620042830.GA10371@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox