From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@meta.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de, sagi@grimberg.me,
ming.lei@redhat.com, brookxu.cn@gmail.com,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH 3/3] nvme: disable controller on reset state failure
Date: Thu, 29 Jun 2023 07:23:26 +0200 [thread overview]
Message-ID: <20230629052326.GC16819@lst.de> (raw)
In-Reply-To: <20230628145814.1068653-3-kbusch@meta.com>
On Wed, Jun 28, 2023 at 07:58:14AM -0700, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> If the controller is not in a RESETTING state at the point of reset
> work, we have to conclude the controller is being deleted. Go to the
> cleanup on this condition to ensure proper pairing of request_queue
> quiesce state.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2023-06-29 5:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 14:58 [PATCH 1/3] nvme: ensure unquiesce on teardown Keith Busch
2023-06-28 14:58 ` [PATCH 2/3] nvme: sync timeout work on failed reset Keith Busch
2023-06-29 5:22 ` Christoph Hellwig
2023-06-28 14:58 ` [PATCH 3/3] nvme: disable controller on reset state failure Keith Busch
2023-06-29 5:23 ` Christoph Hellwig [this message]
2023-06-29 5:22 ` [PATCH 1/3] nvme: ensure unquiesce on teardown Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230629052326.GC16819@lst.de \
--to=hch@lst.de \
--cc=brookxu.cn@gmail.com \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox