From: Kanchan Joshi <joshi.k@samsung.com>
To: Ankit Kumar <ankit.kumar@samsung.com>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
gost.dev@samsung.com, linux-nvme@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme:fix the NVME_ID_NS_NVM_STS_MASK definition
Date: Tue, 4 Jul 2023 17:45:33 +0530 [thread overview]
Message-ID: <20230704121516.GA31441@green245> (raw)
In-Reply-To: <20230623123806.78451-1-ankit.kumar@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 751 bytes --]
On Fri, Jun 23, 2023 at 06:08:05PM +0530, Ankit Kumar wrote:
>As per NVMe command set specification 1.0c Storage tag size is 7 bits
>Fixes: 4020aad85c67 ("nvme: add support for enhanced metadata")
>
>Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>
>---
> include/linux/nvme.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/include/linux/nvme.h b/include/linux/nvme.h
>index 779507ac750b..2819d6c3a6b5 100644
>--- a/include/linux/nvme.h
>+++ b/include/linux/nvme.h
>@@ -473,7 +473,7 @@ struct nvme_id_ns_nvm {
> };
>
> enum {
>- NVME_ID_NS_NVM_STS_MASK = 0x3f,
>+ NVME_ID_NS_NVM_STS_MASK = 0x7f,
Right, 7 bits are needed there to speak the max possible value (i.e.,64).
Reviewed-by: Kanchan Joshi <joshi.k@samsung.com>
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2023-07-04 12:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230623071848epcas5p10d8edb4c9c8673ba612f4b81119ed2fb@epcas5p1.samsung.com>
2023-06-23 12:38 ` [PATCH] nvme:fix the NVME_ID_NS_NVM_STS_MASK definition Ankit Kumar
2023-07-04 12:15 ` Kanchan Joshi [this message]
2023-07-10 16:13 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230704121516.GA31441@green245 \
--to=joshi.k@samsung.com \
--cc=ankit.kumar@samsung.com \
--cc=axboe@kernel.dk \
--cc=gost.dev@samsung.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox