* [PATCH] nvme:fix the NVME_ID_NS_NVM_STS_MASK definition [not found] <CGME20230623071848epcas5p10d8edb4c9c8673ba612f4b81119ed2fb@epcas5p1.samsung.com> @ 2023-06-23 12:38 ` Ankit Kumar 2023-07-04 12:15 ` Kanchan Joshi 2023-07-10 16:13 ` Keith Busch 0 siblings, 2 replies; 3+ messages in thread From: Ankit Kumar @ 2023-06-23 12:38 UTC (permalink / raw) To: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg, Martin K. Petersen Cc: gost.dev, Ankit Kumar, linux-nvme, linux-kernel As per NVMe command set specification 1.0c Storage tag size is 7 bits Fixes: 4020aad85c67 ("nvme: add support for enhanced metadata") Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com> --- include/linux/nvme.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/nvme.h b/include/linux/nvme.h index 779507ac750b..2819d6c3a6b5 100644 --- a/include/linux/nvme.h +++ b/include/linux/nvme.h @@ -473,7 +473,7 @@ struct nvme_id_ns_nvm { }; enum { - NVME_ID_NS_NVM_STS_MASK = 0x3f, + NVME_ID_NS_NVM_STS_MASK = 0x7f, NVME_ID_NS_NVM_GUARD_SHIFT = 7, NVME_ID_NS_NVM_GUARD_MASK = 0x3, }; -- 2.34.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme:fix the NVME_ID_NS_NVM_STS_MASK definition 2023-06-23 12:38 ` [PATCH] nvme:fix the NVME_ID_NS_NVM_STS_MASK definition Ankit Kumar @ 2023-07-04 12:15 ` Kanchan Joshi 2023-07-10 16:13 ` Keith Busch 1 sibling, 0 replies; 3+ messages in thread From: Kanchan Joshi @ 2023-07-04 12:15 UTC (permalink / raw) To: Ankit Kumar Cc: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg, Martin K. Petersen, gost.dev, linux-nvme, linux-kernel [-- Attachment #1: Type: text/plain, Size: 751 bytes --] On Fri, Jun 23, 2023 at 06:08:05PM +0530, Ankit Kumar wrote: >As per NVMe command set specification 1.0c Storage tag size is 7 bits >Fixes: 4020aad85c67 ("nvme: add support for enhanced metadata") > >Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com> >--- > include/linux/nvme.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/include/linux/nvme.h b/include/linux/nvme.h >index 779507ac750b..2819d6c3a6b5 100644 >--- a/include/linux/nvme.h >+++ b/include/linux/nvme.h >@@ -473,7 +473,7 @@ struct nvme_id_ns_nvm { > }; > > enum { >- NVME_ID_NS_NVM_STS_MASK = 0x3f, >+ NVME_ID_NS_NVM_STS_MASK = 0x7f, Right, 7 bits are needed there to speak the max possible value (i.e.,64). Reviewed-by: Kanchan Joshi <joshi.k@samsung.com> [-- Attachment #2: Type: text/plain, Size: 0 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme:fix the NVME_ID_NS_NVM_STS_MASK definition 2023-06-23 12:38 ` [PATCH] nvme:fix the NVME_ID_NS_NVM_STS_MASK definition Ankit Kumar 2023-07-04 12:15 ` Kanchan Joshi @ 2023-07-10 16:13 ` Keith Busch 1 sibling, 0 replies; 3+ messages in thread From: Keith Busch @ 2023-07-10 16:13 UTC (permalink / raw) To: Ankit Kumar Cc: Jens Axboe, Christoph Hellwig, Sagi Grimberg, Martin K. Petersen, gost.dev, linux-nvme, linux-kernel Thanks, applied. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-10 16:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20230623071848epcas5p10d8edb4c9c8673ba612f4b81119ed2fb@epcas5p1.samsung.com>
2023-06-23 12:38 ` [PATCH] nvme:fix the NVME_ID_NS_NVM_STS_MASK definition Ankit Kumar
2023-07-04 12:15 ` Kanchan Joshi
2023-07-10 16:13 ` Keith Busch
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox