From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60184EB64DC for ; Thu, 6 Jul 2023 12:41:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2S0IzQn0gPFpzA761PAxY4/K2beD6+zljZR8iqpFxG0=; b=BYZK7b5v9QuAW4q4MYepSL1WEG eIuR6e59zu633/pp3V21RldFRZdUugPd+H9YpT6iLl1o9CI7vmysSp5d55YxGPdz8NZqaIwaxx5p+ cXNBx5cF1gkFBw96T+0LYViceMIql9hUy+1JLmKCcZlIyCn4PMIQIUIivD4Q6xphzCyK8WpNLL5pm eTo2aJOCWQiVLA0+iYqqLI6y5y+dyyA1QWR6/eoTcnV4/Nw2jajr6J7zBQ+vg80MdTuBD2DRWPc3I xKmIzhM6DIRjqorVFufAoceNafJRYe7JGW2vnKuA9O1HDi0wNIEPjZzKTDnzTL6QDeAW8iX+OrMgD oj2GcVDQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qHOIS-001f5S-1Q; Thu, 06 Jul 2023 12:41:20 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qHOIP-001f4Q-0I for linux-nvme@lists.infradead.org; Thu, 06 Jul 2023 12:41:18 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 6CF8468AFE; Thu, 6 Jul 2023 14:41:14 +0200 (CEST) Date: Thu, 6 Jul 2023 14:41:14 +0200 From: Christoph Hellwig To: Damien Le Moal Cc: linux-block@vger.kernel.org, Jens Axboe , linux-nvme@lists.infradead.org, Christoph Hellwig , Keith Busch , linux-scsi@vger.kernel.org, "Martin K . Petersen" Subject: Re: [PATCH v2 3/5] block: nullblk: Set zone limits before revalidating zones Message-ID: <20230706124114.GC12545@lst.de> References: <20230630083935.433334-1-dlemoal@kernel.org> <20230630083935.433334-4-dlemoal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230630083935.433334-4-dlemoal@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230706_054117_277322_3523DE58 X-CRM114-Status: GOOD ( 11.33 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Fri, Jun 30, 2023 at 05:39:33PM +0900, Damien Le Moal wrote: > + if (queue_is_mq(q)) > + return blk_revalidate_disk_zones(nullb->disk, NULL); > + > return 0; I'd write this as: if (!queue_is_mq(q))) return 0; return blk_revalidate_disk_zones(nullb->disk, NULL); but that's just cosmetic. Otherwise looks good: Reviewed-by: Christoph Hellwig