From: Christoph Hellwig <hch@lst.de>
To: irvin cote <irvincoteg@gmail.com>
Cc: Max Gurtovoy <mgurtovoy@nvidia.com>,
hch@lst.de, kbusch@kernel.org, axboe@kernel.dk, sagi@grimberg.me,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme-core: check id->mc before setting NVME_NS_METADATA_SUPPORTED
Date: Mon, 10 Jul 2023 09:01:10 +0200 [thread overview]
Message-ID: <20230710070110.GA26047@lst.de> (raw)
In-Reply-To: <CALL+9egLCiTFyOpvt9tUhmkr-x3PoCzi3JeDxZ-FTCyP7BkDxw@mail.gmail.com>
On Fri, Jun 30, 2023 at 07:41:27PM +0200, irvin cote wrote:
> >The MC field is primarily for use when sending a format command to know
> >what are valid possibilities. If the reported MS and FLBAS are out of
> >sync with metadata capabilities, then the controller is broken.
>
> Beware having MC and FLBAS out of sync does not necessarily mean we
> have a broken controller :
> MC could be 0 (no metadata support at all) and FLBAS has no way to
> express that, it can only indicate which metadata type was selected by
> the user.
> In such a case we could wrongfully signal metadata as supported when it is not
The LBA Format Data Structure indicates the metadata size for any
given format.
prev parent reply other threads:[~2023-07-10 7:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-24 10:35 [PATCH] nvme-core: check id->mc before setting NVME_NS_METADATA_SUPPORTED Irvin Cote
2023-06-27 15:30 ` Keith Busch
2023-06-27 16:02 ` Max Gurtovoy
2023-06-30 17:41 ` irvin cote
2023-07-02 14:02 ` irvin cote
2023-07-10 7:01 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230710070110.GA26047@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=irvincoteg@gmail.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mgurtovoy@nvidia.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox