linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
	linux-nvme@lists.infradead.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
	Wen Xiong <wenxiong@linux.ibm.com>,
	Keith Busch <kbusch@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/8] blk-mq: add blk_mq_max_nr_hw_queues()
Date: Wed, 12 Jul 2023 15:19:25 +0200	[thread overview]
Message-ID: <20230712131925.GA14596@lst.de> (raw)
In-Reply-To: <ZK6nm2koR+TfeMcs@ovpn-8-25.pek2.redhat.com>

On Wed, Jul 12, 2023 at 09:16:11PM +0800, Ming Lei wrote:
> The problem is that blk_mq_alloc_tag_set() forces to set nr_hw_queues
> as 1 for kdump kernel, that is why blk_mq_max_nr_hw_queues() has to
> return 1 for kdump kernel.

Well, let's fix that first and work from there.  Same argument against
that deep magic applies there as well.

> Thomas, can we disable managed irq for kdump kernel and switch to
> non-managed irq? Then we can avoid driver's change. I'd suggest
> this way if it is possible.

Why the heck would we?



  reply	other threads:[~2023-07-12 13:19 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-12 12:54 [PATCH 0/8] blk-mq: fix wrong queue mapping for kdump kernel Ming Lei
2023-07-12 12:54 ` [PATCH 1/8] blk-mq: add blk_mq_max_nr_hw_queues() Ming Lei
2023-07-12 13:00   ` Christoph Hellwig
2023-07-12 13:16     ` Ming Lei
2023-07-12 13:19       ` Christoph Hellwig [this message]
2023-07-12 13:31         ` Ming Lei
2023-07-12 12:54 ` [PATCH 2/8] nvme-pci: use blk_mq_max_nr_hw_queues() to calculate io queues Ming Lei
2023-07-12 12:54 ` [PATCH 3/8] scsi: lpfc: use blk_mq_max_nr_hw_queues() to calculate io vectors Ming Lei
2023-07-13  0:03   ` Justin Tee
2023-07-21  8:48     ` Ming Lei
2023-07-12 12:54 ` [PATCH 4/8] scsi: hisi: take blk_mq_max_nr_hw_queues() into account for calculating " Ming Lei
2023-07-12 12:54 ` [PATCH 5/8] scsi: mpi3mr: " Ming Lei
2023-07-12 12:54 ` [PATCH 6/8] scsi: megaraid: " Ming Lei
2023-07-12 12:54 ` [PATCH 7/8] scsi: mpt3sas: " Ming Lei
2023-07-12 12:54 ` [PATCH 8/8] scsi: pm8001: " Ming Lei
2023-07-12 13:12   ` Jinpu Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230712131925.GA14596@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=ming.lei@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=wenxiong@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).