From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@meta.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de, sagi@grimberg.me,
Keith Busch <kbusch@kernel.org>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>,
Breno Leitao <leitao@debian.org>
Subject: Re: [PATCH] nvme: warn only once for legacy uuid attribute
Date: Wed, 12 Jul 2023 17:02:29 +0200 [thread overview]
Message-ID: <20230712150229.GA22618@lst.de> (raw)
In-Reply-To: <20230712145921.85333-1-kbusch@meta.com>
On Wed, Jul 12, 2023 at 07:59:21AM -0700, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> Report the legacy fallback behavior for uuid attributes just once
> instead of logging repeated warnings for the same condition every time
> the attribute is read. The old behavior is too spamy on the kernel logs.
Warning on allocation just seems wrong - no uuid is perfectly fine.
I think what we should do is warn once when reading the attribute
and then never again.
prev parent reply other threads:[~2023-07-12 15:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 14:59 [PATCH] nvme: warn only once for legacy uuid attribute Keith Busch
2023-07-12 15:02 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230712150229.GA22618@lst.de \
--to=hch@lst.de \
--cc=johannes.thumshirn@wdc.com \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=leitao@debian.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox