* [PATCHv2] nvme: warn only once for legacy uuid attribute
@ 2023-07-12 15:26 Keith Busch
2023-07-12 15:44 ` Christoph Hellwig
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Keith Busch @ 2023-07-12 15:26 UTC (permalink / raw)
To: linux-nvme, hch, sagi; +Cc: Keith Busch, Johannes Thumshirn, Breno Leitao
From: Keith Busch <kbusch@kernel.org>
Report the legacy fallback behavior for uuid attributes just once
instead of logging repeated warnings for the same condition every time
the attribute is read. The old behavior is too spamy on the kernel logs.
Cc: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reported-by: Breno Leitao <leitao@debian.org>
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
drivers/nvme/host/sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/sysfs.c b/drivers/nvme/host/sysfs.c
index 45e91811f905c..212e1b05d2984 100644
--- a/drivers/nvme/host/sysfs.c
+++ b/drivers/nvme/host/sysfs.c
@@ -92,7 +92,7 @@ static ssize_t uuid_show(struct device *dev, struct device_attribute *attr,
* we have no UUID set
*/
if (uuid_is_null(&ids->uuid)) {
- dev_warn_ratelimited(dev,
+ dev_warn_once(dev,
"No UUID available providing old NGUID\n");
return sysfs_emit(buf, "%pU\n", ids->nguid);
}
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCHv2] nvme: warn only once for legacy uuid attribute
2023-07-12 15:26 [PATCHv2] nvme: warn only once for legacy uuid attribute Keith Busch
@ 2023-07-12 15:44 ` Christoph Hellwig
2023-07-13 6:43 ` Johannes Thumshirn
2023-07-13 7:40 ` Sagi Grimberg
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2023-07-12 15:44 UTC (permalink / raw)
To: Keith Busch
Cc: linux-nvme, hch, sagi, Keith Busch, Johannes Thumshirn,
Breno Leitao
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCHv2] nvme: warn only once for legacy uuid attribute
2023-07-12 15:26 [PATCHv2] nvme: warn only once for legacy uuid attribute Keith Busch
2023-07-12 15:44 ` Christoph Hellwig
@ 2023-07-13 6:43 ` Johannes Thumshirn
2023-07-13 7:40 ` Sagi Grimberg
2 siblings, 0 replies; 4+ messages in thread
From: Johannes Thumshirn @ 2023-07-13 6:43 UTC (permalink / raw)
To: Keith Busch, linux-nvme@lists.infradead.org, hch@lst.de,
sagi@grimberg.me
Cc: Keith Busch, Breno Leitao
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCHv2] nvme: warn only once for legacy uuid attribute
2023-07-12 15:26 [PATCHv2] nvme: warn only once for legacy uuid attribute Keith Busch
2023-07-12 15:44 ` Christoph Hellwig
2023-07-13 6:43 ` Johannes Thumshirn
@ 2023-07-13 7:40 ` Sagi Grimberg
2 siblings, 0 replies; 4+ messages in thread
From: Sagi Grimberg @ 2023-07-13 7:40 UTC (permalink / raw)
To: Keith Busch, linux-nvme, hch
Cc: Keith Busch, Johannes Thumshirn, Breno Leitao
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-13 7:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-12 15:26 [PATCHv2] nvme: warn only once for legacy uuid attribute Keith Busch
2023-07-12 15:44 ` Christoph Hellwig
2023-07-13 6:43 ` Johannes Thumshirn
2023-07-13 7:40 ` Sagi Grimberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox