From: Kanchan Joshi <joshi.k@samsung.com>
To: Christoph Hellwig <hch@lst.de>
Cc: kbusch@kernel.org, sagi@grimberg.me, axboe@kernel.dk,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: don't reject probe due to duplicate IDs for single-ported PCIe devices
Date: Thu, 13 Jul 2023 19:32:06 +0530 [thread overview]
Message-ID: <20230713140156.GA2143@green245> (raw)
In-Reply-To: <20230713133042.3981-1-hch@lst.de>
[-- Attachment #1: Type: text/plain, Size: 778 bytes --]
On Thu, Jul 13, 2023 at 03:30:42PM +0200, Christoph Hellwig wrote:
>While duplicate IDs are still very harmful, including the potential to easily
>see changing devices in /dev/disk/by-id, it turn out they are extremely
>common for cheap end user NVMe devices.
>
>Relax our check for them for so that it doesn't reject the probe on
>single-ported PCIe devices, but prints a big warning instead. In doubt
>we'd still like to see quirk entries to disable the potential for
>changing supposed stable device identifier links, but this will at least
>allow users how have two (or more) of these devices to use them without
>having to manually add a new PCI ID entry with the quirk through sysfs or
>by patching the kernel.
Should this go for backport? For the commit 2079f41ec6ffa.
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2023-07-13 14:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230713133859epcas5p2b0de1a117d69f54f2d1dcf027f73afef@epcas5p2.samsung.com>
2023-07-13 13:30 ` [PATCH] nvme: don't reject probe due to duplicate IDs for single-ported PCIe devices Christoph Hellwig
2023-07-13 14:02 ` Kanchan Joshi [this message]
2023-07-13 14:54 ` Keith Busch
2023-07-13 15:01 ` Jens Axboe
2023-07-13 15:20 ` Keith Busch
2026-01-20 9:54 ` xiaoke
2026-01-22 6:38 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230713140156.GA2143@green245 \
--to=joshi.k@samsung.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox