From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org
Cc: linux-block@vger.kernel.org, Wen Xiong <wenxiong@linux.ibm.com>,
Keith Busch <kbusch@kernel.org>, Ming Lei <ming.lei@redhat.com>
Subject: [PATCH V2 0/9] blk-mq: fix wrong queue mapping for kdump kernel
Date: Wed, 26 Jul 2023 17:40:18 +0800 [thread overview]
Message-ID: <20230726094027.535126-1-ming.lei@redhat.com> (raw)
Hi,
On arm and ppc64, 'maxcpus=1' is required for kdump kernel,
see `Documentation/admin-guide/kdump/kdump.rst`, so num_possible_cpus()
still returns all CPUs because 'maxcpus=1' just bring up one single
cpu core during booting.
blk-mq sees single queue in kdump kernel, and in driver's viewpoint
there are still multiple queues, this inconsistency causes driver to apply
wrong queue mapping for handling IO, and IO timeout is triggered.
This issue is only triggered on managed irq in case of multiple hw
queues. Some drivers takes online cpus into account for nr_hw_queues,
and don't have such issue, such as nvme rdma/tcp.
Meantime, single queue makes much less resource utilization, and reduce
risk of kernel failure.
V2:
- add helper of scsi_max_nr_hw_queues() for avoiding potential build
failure because scsi driver often doesn't deal with blk-mq directly
- apply scsi_max_nr_hw_queues() for all scsi changes
- move lpfc's change into managed irq code path
Thanks,
Ming
Ming Lei (9):
blk-mq: add blk_mq_max_nr_hw_queues()
nvme-pci: use blk_mq_max_nr_hw_queues() to calculate io queues
scsi: core: add helper of scsi_max_nr_hw_queues()
scsi: lpfc: use blk_mq_max_nr_hw_queues() to calculate io vectors
scsi: hisi: take blk_mq_max_nr_hw_queues() into account for
calculating io vectors
scsi: mpi3mr: take blk_mq_max_nr_hw_queues() into account for
calculating io vectors
scsi: megaraid: take blk_mq_max_nr_hw_queues() into account for
calculating io vectors
scsi: mpt3sas: take blk_mq_max_nr_hw_queues() into account for
calculating io vectors
scsi: pm8001: take blk_mq_max_nr_hw_queues() into account for
calculating io vectors
block/blk-mq.c | 16 ++++++++++++++++
drivers/nvme/host/pci.c | 2 +-
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 3 +++
drivers/scsi/lpfc/lpfc_init.c | 2 ++
drivers/scsi/megaraid/megaraid_sas_base.c | 6 +++++-
drivers/scsi/mpi3mr/mpi3mr_fw.c | 3 +++
drivers/scsi/mpt3sas/mpt3sas_base.c | 4 ++--
drivers/scsi/pm8001/pm8001_init.c | 4 +++-
include/linux/blk-mq.h | 1 +
include/scsi/scsi_host.h | 5 +++++
10 files changed, 41 insertions(+), 5 deletions(-)
--
2.40.1
next reply other threads:[~2023-07-26 9:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 9:40 Ming Lei [this message]
2023-07-26 9:40 ` [PATCH V2 1/9] blk-mq: add blk_mq_max_nr_hw_queues() Ming Lei
2023-07-26 16:36 ` John Garry
2023-07-27 1:06 ` Ming Lei
2023-07-26 9:40 ` [PATCH V2 2/9] nvme-pci: use blk_mq_max_nr_hw_queues() to calculate io queues Ming Lei
2023-07-26 9:40 ` [PATCH V2 3/9] scsi: core: add helper of scsi_max_nr_hw_queues() Ming Lei
2023-07-26 9:40 ` [PATCH V2 4/9] scsi: lpfc: use blk_mq_max_nr_hw_queues() to calculate io vectors Ming Lei
2023-07-26 22:12 ` Justin Tee
2023-07-27 1:19 ` Ming Lei
2023-07-27 16:56 ` Justin Tee
2023-07-26 9:40 ` [PATCH V2 5/9] scsi: hisi: take blk_mq_max_nr_hw_queues() into account for calculating " Ming Lei
2023-07-26 15:42 ` John Garry
2023-07-27 1:15 ` Ming Lei
2023-07-27 7:35 ` John Garry
2023-07-27 9:42 ` Ming Lei
2023-07-27 10:28 ` John Garry
2023-07-27 10:56 ` Ming Lei
2023-07-27 11:30 ` John Garry
2023-07-27 12:01 ` Ming Lei
2023-07-27 12:36 ` John Garry
2023-07-26 9:40 ` [PATCH V2 6/9] scsi: mpi3mr: " Ming Lei
2023-07-26 9:40 ` [PATCH V2 7/9] scsi: megaraid: " Ming Lei
2023-07-26 9:40 ` [PATCH V2 8/9] scsi: mpt3sas: " Ming Lei
2023-07-26 9:40 ` [PATCH V2 9/9] scsi: pm8001: " Ming Lei
2023-07-31 7:14 ` [PATCH V2 0/9] blk-mq: fix wrong queue mapping for kdump kernel Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230726094027.535126-1-ming.lei@redhat.com \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=wenxiong@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).