From: Christoph Hellwig <hch@lst.de>
To: Varun Prakash <varun@chelsio.com>
Cc: sagi@grimberg.me, hch@lst.de, linux-nvme@lists.infradead.org,
Rakshana Sridhar <rakshanas@chelsio.com>
Subject: Re: [PATCH] nvmet-tcp: fix data digest calculation for multiple H2CData PDUs
Date: Mon, 31 Jul 2023 08:01:19 +0200 [thread overview]
Message-ID: <20230731060119.GD30150@lst.de> (raw)
In-Reply-To: <20230727150731.5905-1-varun@chelsio.com>
On Thu, Jul 27, 2023 at 08:37:31PM +0530, Varun Prakash wrote:
> On receiving H2CData PDU current code calculates data digest for the entire
> transfer length, it works if host sends only one H2CData PDU per cmd, if
> host sends multiple H2CData PDU per cmd then target reports data digest
> error.
>
> This issue was fixed in commit fda871c0ba5d ("nvmet-tcp: fix receive data
> digest calculation for multiple h2cdata PDUs").
>
> commit ed0691cf5514 ("nvmet-tcp: fix regression in data_digest
> calculation") reverted the fix done in the above commit.
This simply seems to revert this revert again and not address the
reason why it was reverted.
next prev parent reply other threads:[~2023-07-31 6:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 15:07 [PATCH] nvmet-tcp: fix data digest calculation for multiple H2CData PDUs Varun Prakash
2023-07-31 6:01 ` Christoph Hellwig [this message]
2023-07-31 13:43 ` Sagi Grimberg
2023-07-31 13:48 ` Sagi Grimberg
2023-08-01 8:26 ` Varun Prakash
2023-08-01 13:07 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230731060119.GD30150@lst.de \
--to=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=rakshanas@chelsio.com \
--cc=sagi@grimberg.me \
--cc=varun@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox