From: Christoph Hellwig <hch@lst.de>
To: "Limonciello, Mario" <mario.limonciello@amd.com>
Cc: August Wikerfors <git@augustwikerfors.se>,
Keith Busch <kbusch@kernel.org>,
axboe@fb.com, hch@lst.de, sagi@grimberg.me,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
nilskruse97@gmail.com, David.Chang@amd.com
Subject: Re: [PATCH] nvme: Don't fail to resume if NSIDs change
Date: Mon, 31 Jul 2023 22:10:47 +0200 [thread overview]
Message-ID: <20230731201047.GA14034@lst.de> (raw)
In-Reply-To: <39697f68-9dc8-7692-7210-b75cce32c6ce@amd.com>
On Mon, Jul 31, 2023 at 03:09:08PM -0500, Limonciello, Mario wrote:
> So is it reasonable to just add a check for
>
> ctrl->oacs & NVME_CTRL_OACS_NS_MNGT_SUPP
>
> In the same error handling path as this patch?
No. There are tons of NVMe devices that only support creating and
deleting namespace out of band, especially in virtualized and cloud
setups.
next prev parent reply other threads:[~2023-07-31 20:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 18:51 [PATCH] nvme: Don't fail to resume if NSIDs change Mario Limonciello
2023-07-31 19:10 ` Keith Busch
2023-07-31 19:41 ` Christoph Hellwig
2023-07-31 19:54 ` August Wikerfors
2023-07-31 20:09 ` Limonciello, Mario
2023-07-31 20:10 ` Christoph Hellwig [this message]
2023-07-31 20:14 ` Limonciello, Mario
2023-08-01 11:24 ` Christoph Hellwig
2023-08-01 11:30 ` Mario Limonciello
2023-08-01 20:29 ` Keith Busch
2023-08-01 20:34 ` Mario Limonciello
2023-08-11 20:19 ` August Wikerfors
2023-08-11 20:59 ` Keith Busch
2023-08-12 5:57 ` Greg KH
2023-08-12 5:57 ` Greg KH
2023-07-31 19:11 ` August Wikerfors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230731201047.GA14034@lst.de \
--to=hch@lst.de \
--cc=David.Chang@amd.com \
--cc=axboe@fb.com \
--cc=git@augustwikerfors.se \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mario.limonciello@amd.com \
--cc=nilskruse97@gmail.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox