Re: [PATCH 12/14] nvmet-tcp: allocate socket file

Sagi Grimberg
2023-08-07T08:53:38Z

>>> -static int nvmet_tcp_alloc_queue(struct nvmet_tcp_port *port,
>>> +static void nvmet_tcp_alloc_queue(struct nvmet_tcp_port *port,
>>>           struct socket *newsock)
>>
>> Why does the function change from retcode to void in this patch?
>
> Because the return code was never evaluated.

??

I see it is evaluated.