Re: [PATCH 09/14] nvme-tcp: control message handling for recvmsg()

Hannes Reinecke
2023-08-08T11:56:17Z

On 8/8/23 13:45, Sagi Grimberg wrote:
>
>> Hi all,
>>
>> I'm testing this patchset and observe the issue with above.
>> It's not only about passing cbuf, but the check below.
>> When I would like to connect/discover without TLS,
>> I got an error about unhandled TLS record.
>> tls_get_record_type() simply returns 0 for non-TLS,
>> so it breaks non-tls connections here.
>
> Hannes?
>
> probably need to make sure to test without tls (sweep
> blktests should be enough).

Yeah, will do.

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Frankenstr. 146, 90461 Nürnberg
Managing Directors: I. Totev, A. Myers, A. McDonald, M. B. Moerman
(HRB 36809, AG Nürnberg)