Re: [PATCH 12/14] nvmet-tcp: allocate socket file

Hannes Reinecke
2023-08-08T06:09:08Z

On 8/7/23 12:42, Sagi Grimberg wrote:
>
>>>>>> -static int nvmet_tcp_alloc_queue(struct nvmet_tcp_port *port,
>>>>>> +static void nvmet_tcp_alloc_queue(struct nvmet_tcp_port *port,
>>>>>>           struct socket *newsock)
>>>>>
>>>>> Why does the function change from retcode to void in this patch?
>>>>
>>>> Because the return code was never evaluated.
>>>
>>> ??
>>>
>>> I see it is evaluated.
>>
>> Yes, but this patch moved the 'sock_release()' call into
>> nvmet_tcp_alloc_queue(), making the return code obsolete.
>>
>> But I can make it a separate patch if required.
>
> But now who calls sock_release if you failed before allocating
> the sockfile?
>
That is done in nvmet_tcp_remove_port(), and independent on
queue release.

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew
Myers, Andrew McDonald, Martje Boudien Moerman