Re: [PATCH 12/14] nvmet-tcp: allocate socket file

Sagi Grimberg
2023-08-07T10:42:52Z

>>>>> -static int nvmet_tcp_alloc_queue(struct nvmet_tcp_port *port,
>>>>> +static void nvmet_tcp_alloc_queue(struct nvmet_tcp_port *port,
>>>>>           struct socket *newsock)
>>>>
>>>> Why does the function change from retcode to void in this patch?
>>>
>>> Because the return code was never evaluated.
>>
>> ??
>>
>> I see it is evaluated.
>
> Yes, but this patch moved the 'sock_release()' call into
> nvmet_tcp_alloc_queue(), making the return code obsolete.
>
> But I can make it a separate patch if required.

But now who calls sock_release if you failed before allocating
the sockfile?