From: Kanchan Joshi <joshi.k@samsung.com>
To: Ming Lei <ming.lei@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org, Sagi Grimberg <sagi@grimberg.me>,
Guangwu Zhang <guazhang@redhat.com>,
Anuj Gupta <anuj20.g@samsung.com>
Subject: Re: [PATCH] nvme: core: don't hold rcu read lock in nvme_ns_chr_uring_cmd_iopoll
Date: Wed, 9 Aug 2023 12:29:20 +0530 [thread overview]
Message-ID: <20230809065920.GA19415@green245> (raw)
In-Reply-To: <20230809020440.174682-1-ming.lei@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 840 bytes --]
On Wed, Aug 09, 2023 at 10:04:40AM +0800, Ming Lei wrote:
>Now nvme_ns_chr_uring_cmd_iopoll() has switched to request based io
>polling, and the associated NS is guaranteed to be live in case of
>io polling, so request is guaranteed to be valid because blk-mq uses
>pre-allocated request pool.
>
>Remove the rcu read lock in nvme_ns_chr_uring_cmd_iopoll(), which
>isn't needed any more after switching to request based io polling.
>Fix "BUG: sleeping function called from invalid context" because
>set_page_dirty_lock() from blk_rq_unmap_user() may sleep.
>
>Fixes: 585079b6e425 ("nvme: wire up async polling for io passthrough commands")
>Reported-by: Guangwu Zhang <guazhang@redhat.com>
Thanks Ming. Looks fine, but any link to this report?
I don't see this breaking in my tests.
So I wonder how to reproduce and improve the coverage.
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2023-08-09 7:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230809020844epcas5p30e520491fa59ab8c20836d4275931e8f@epcas5p3.samsung.com>
2023-08-09 2:04 ` [PATCH] nvme: core: don't hold rcu read lock in nvme_ns_chr_uring_cmd_iopoll Ming Lei
2023-08-09 6:59 ` Kanchan Joshi [this message]
2023-08-09 7:53 ` Ming Lei
2023-08-10 6:34 ` Kanchan Joshi
2023-08-10 8:14 ` Ming Lei
2023-08-11 14:12 ` Jens Axboe
2023-08-11 14:12 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230809065920.GA19415@green245 \
--to=joshi.k@samsung.com \
--cc=anuj20.g@samsung.com \
--cc=guazhang@redhat.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox