From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19CC5C04A6A for ; Fri, 11 Aug 2023 12:18:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/bf4aS8yyGY6kDsuYG7mumSGztmZQ1gBwZTJUOnpvNc=; b=wW8ypCY6CIGV/0he96WS/i3L3f EbAeRVDd8iN1+CStrdFapam8RBOfb3fNky8nzBY6eHbjaR9sFsTvHX1LjiWsJ31czYTcBBzPbQo0I a+ylADRkdIRIyyAAf3MzySESETxGogcYqQ9lIKE7V6calK60b+0EtqSE/YYV0NiucmxoWQIY74BGN SNcx2RpDVTLDVvT8GLdbi1OF11hrU5vKmxIH/9dZZJq4PyqIe7IdSRIBHllZi8KQcKjINfMPtRs2S LoBNw6WoOC/2Xj0c6fvEZ0Qip4HusmjpaUH9sW0ZJrhx1iqxrDOzOj/O5s+P5BFeowo/TaKJ7SMUq PUX+r46Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qUR6D-00AZPb-1g; Fri, 11 Aug 2023 12:18:37 +0000 Received: from smtp-out1.suse.de ([2001:67c:2178:6::1c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qUR5p-00AZ4g-1M for linux-nvme@lists.infradead.org; Fri, 11 Aug 2023 12:18:16 +0000 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 60E5A21886; Fri, 11 Aug 2023 12:18:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1691756286; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/bf4aS8yyGY6kDsuYG7mumSGztmZQ1gBwZTJUOnpvNc=; b=aHgyvGYqI3a80W+LicYJI/9IXyOCemwL410BOWcFToqAhjmVYcE9b84qvNj8LO7G3E+LQD n2HlqU8U1k47PcibqlTuV+gITCOh+nf3+E5ht8PEcJJNuVu9hOxX+Sog5Kv/stX+mKfquY ygjIGX+51eWgZiAEZy2tlOhq2RCeSok= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1691756286; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/bf4aS8yyGY6kDsuYG7mumSGztmZQ1gBwZTJUOnpvNc=; b=7v7yr9e5s3UEyKHoGVOcPQNL7R3B15oT7HRaioGnWXuaav04y6LtH4yeKGvTMCo9l6+2Nj Hhd39+Zihk1fG1Dg== Received: from adalid.arch.suse.de (adalid.arch.suse.de [10.161.8.13]) by relay2.suse.de (Postfix) with ESMTP id 4B94B2C161; Fri, 11 Aug 2023 12:18:06 +0000 (UTC) Received: by adalid.arch.suse.de (Postfix, from userid 16045) id 4845451CAF02; Fri, 11 Aug 2023 14:18:06 +0200 (CEST) From: Hannes Reinecke To: Christoph Hellwig Cc: Sagi Grimberg , Keith Busch , linux-nvme@lists.infradead.org, Jakub Kicinski , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, Hannes Reinecke Subject: [PATCH 15/17] nvmet: Set 'TREQ' to 'required' when TLS is enabled Date: Fri, 11 Aug 2023 14:17:53 +0200 Message-Id: <20230811121755.24715-16-hare@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230811121755.24715-1-hare@suse.de> References: <20230811121755.24715-1-hare@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230811_051813_638993_D8F37570 X-CRM114-Status: GOOD ( 12.30 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org The current implementation does not support secure concatenation, so 'TREQ' is always set to 'required' when TLS is enabled. Signed-off-by: Hannes Reinecke --- drivers/nvme/target/configfs.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/nvme/target/configfs.c b/drivers/nvme/target/configfs.c index 53862f2c6cd1..efbfed310370 100644 --- a/drivers/nvme/target/configfs.c +++ b/drivers/nvme/target/configfs.c @@ -376,6 +376,7 @@ static ssize_t nvmet_addr_tsas_store(struct config_item *item, const char *page, size_t count) { struct nvmet_port *port = to_nvmet_port(item); + u8 treq = nvmet_port_disc_addr_treq_mask(port); u8 sectype; int i; @@ -397,6 +398,17 @@ static ssize_t nvmet_addr_tsas_store(struct config_item *item, found: nvmet_port_init_tsas_tcp(port, sectype); + /* + * The TLS implementation currently does not support + * secure concatenation, so TREQ is always set to 'required' + * if TLS is enabled. + */ + if (sectype == NVMF_TCP_SECTYPE_TLS13) { + treq |= NVMF_TREQ_REQUIRED; + } else { + treq |= NVMF_TREQ_NOT_SPECIFIED; + } + port->disc_addr.treq = treq; return count; } -- 2.35.3