From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5603AEB64DD for ; Fri, 11 Aug 2023 17:17:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2fs6XE0i6jEINtbNwaIX6cy8RXhepky9Gh21re023Ag=; b=I1MGuSeoChgYRIcQkO8jiZoyqn mOVzGAt/FUs1oP9JWrxmhpYpw/U9rFoHRqI6bc382LX3aHw5pVTy+5iYhS40CjrcJKjNlahEvG8aa dEuHInHPw7Q5Sjgi5/EsFeKDZog1dJN73glYPXOFnqXgc63Gp100TiraKZx16vSj1fNYh9JsYGHgF rHlXOhqB+Rn27fBlwuUybK1c4UhoXO6Bvo7j0GokRBXZbRqUNcQG84k16QTj3PRDc71+j6I7BnB5O QglrelwWvyvJYYF0xJROV4zGvOvH1u5OX9Q4RbL/qS4cdOPSs0qgyoWIQiP88qK1Ag5YQoB0ti7Nf ml9Kj3UA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qUVl0-00BDwe-06; Fri, 11 Aug 2023 17:17:02 +0000 Received: from mgamail.intel.com ([192.55.52.88]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qUVkw-00BDuj-1p for linux-nvme@lists.infradead.org; Fri, 11 Aug 2023 17:17:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691774218; x=1723310218; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=5BBxQbhgYW43hCw+ByPcuzFN1UnPvUH5Tx4ynzXR2sg=; b=cEKi8o9z34//5RoishTqUkazMN2q0Mdg/CI3gAYtIiNw5dZQwv+WJQ75 ZRoWqaDj1gubXU+u9fA7IRT++bXLyCllmgQv/ZjxJqf5Z9dqt9kWLeVYg Q7fQTcz15Msm/P3YA/7y8s3h3jrAu+FR9LOrmJSYaeLFbtcC+W2lSPfxb 7SnKWpOb/N8wfvpLnTq7nYSp0nqcEHfQi2vxNVfMmTBYjE3766vcmmL+v Qk6eJ9RXUyircfkHlcrB8Up3nBRVWWOFy4bus0o4cxSZvKrRy+LQM4s/c tGenIysZgbdGrjAdjjhvQoyGHwqd7cK5sQkpNLA0updRD3mNPnGG2ARjK g==; X-IronPort-AV: E=McAfee;i="6600,9927,10799"; a="402696532" X-IronPort-AV: E=Sophos;i="6.01,166,1684825200"; d="scan'208";a="402696532" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2023 10:16:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10799"; a="979291531" X-IronPort-AV: E=Sophos;i="6.01,166,1684825200"; d="scan'208";a="979291531" Received: from lkp-server01.sh.intel.com (HELO d1ccc7e87e8f) ([10.239.97.150]) by fmsmga006.fm.intel.com with ESMTP; 11 Aug 2023 10:16:46 -0700 Received: from kbuild by d1ccc7e87e8f with local (Exim 4.96) (envelope-from ) id 1qUVkj-0007uS-3C; Fri, 11 Aug 2023 17:16:45 +0000 Date: Sat, 12 Aug 2023 01:16:44 +0800 From: kernel test robot To: Nitesh Shetty , Jens Axboe , Jonathan Corbet , Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com, Keith Busch , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , Alexander Viro , Christian Brauner Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, martin.petersen@oracle.com, mcgrof@kernel.org, dlemoal@kernel.org, gost.dev@samsung.com, Nitesh Shetty , Damien Le Moal , Anuj Gupta , Vincent Fu , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v14 11/11] null_blk: add support for copy offload Message-ID: <202308120029.elW3y1RM-lkp@intel.com> References: <20230811105300.15889-12-nj.shetty@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230811105300.15889-12-nj.shetty@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230811_101658_616007_19ED0509 X-CRM114-Status: GOOD ( 16.74 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org Hi Nitesh, kernel test robot noticed the following build warnings: [auto build test WARNING on f7dc24b3413851109c4047b22997bd0d95ed52a2] url: https://github.com/intel-lab-lkp/linux/commits/Nitesh-Shetty/block-Introduce-queue-limits-and-sysfs-for-copy-offload-support/20230811-192259 base: f7dc24b3413851109c4047b22997bd0d95ed52a2 patch link: https://lore.kernel.org/r/20230811105300.15889-12-nj.shetty%40samsung.com patch subject: [PATCH v14 11/11] null_blk: add support for copy offload config: hexagon-randconfig-r032-20230811 (https://download.01.org/0day-ci/archive/20230812/202308120029.elW3y1RM-lkp@intel.com/config) compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a) reproduce: (https://download.01.org/0day-ci/archive/20230812/202308120029.elW3y1RM-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202308120029.elW3y1RM-lkp@intel.com/ All warnings (new ones prefixed by >>): In file included from drivers/block/null_blk/main.c:12: In file included from drivers/block/null_blk/null_blk.h:8: In file included from include/linux/blkdev.h:9: In file included from include/linux/blk_types.h:10: In file included from include/linux/bvec.h:10: In file included from include/linux/highmem.h:12: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/hexagon/include/asm/io.h:337: include/asm-generic/io.h:547:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 547 | val = __raw_readb(PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:560:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 560 | val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr)); | ~~~~~~~~~~ ^ include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu' 37 | #define __le16_to_cpu(x) ((__force __u16)(__le16)(x)) | ^ In file included from drivers/block/null_blk/main.c:12: In file included from drivers/block/null_blk/null_blk.h:8: In file included from include/linux/blkdev.h:9: In file included from include/linux/blk_types.h:10: In file included from include/linux/bvec.h:10: In file included from include/linux/highmem.h:12: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/hexagon/include/asm/io.h:337: include/asm-generic/io.h:573:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 573 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr)); | ~~~~~~~~~~ ^ include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu' 35 | #define __le32_to_cpu(x) ((__force __u32)(__le32)(x)) | ^ In file included from drivers/block/null_blk/main.c:12: In file included from drivers/block/null_blk/null_blk.h:8: In file included from include/linux/blkdev.h:9: In file included from include/linux/blk_types.h:10: In file included from include/linux/bvec.h:10: In file included from include/linux/highmem.h:12: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/hexagon/include/asm/io.h:337: include/asm-generic/io.h:584:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 584 | __raw_writeb(value, PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:594:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 594 | __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:604:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 604 | __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr); | ~~~~~~~~~~ ^ >> drivers/block/null_blk/main.c:1303:2: warning: variable 'sector_in' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] 1303 | __rq_for_each_bio(bio, req) { | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/blk-mq.h:1008:6: note: expanded from macro '__rq_for_each_bio' 1008 | if ((rq->bio)) \ | ^~~~~~~~~ drivers/block/null_blk/main.c:1316:8: note: uninitialized use occurs here 1316 | sector_in << SECTOR_SHIFT, rem); | ^~~~~~~~~ drivers/block/null_blk/main.c:1303:2: note: remove the 'if' if its condition is always true 1303 | __rq_for_each_bio(bio, req) { | ^ include/linux/blk-mq.h:1008:2: note: expanded from macro '__rq_for_each_bio' 1008 | if ((rq->bio)) \ | ^ drivers/block/null_blk/main.c:1287:20: note: initialize the variable 'sector_in' to silence this warning 1287 | sector_t sector_in, sector_out; | ^ | = 0 >> drivers/block/null_blk/main.c:1303:2: warning: variable 'sector_out' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] 1303 | __rq_for_each_bio(bio, req) { | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/blk-mq.h:1008:6: note: expanded from macro '__rq_for_each_bio' 1008 | if ((rq->bio)) \ | ^~~~~~~~~ drivers/block/null_blk/main.c:1315:27: note: uninitialized use occurs here 1315 | trace_nullb_copy_op(req, sector_out << SECTOR_SHIFT, | ^~~~~~~~~~ drivers/block/null_blk/main.c:1303:2: note: remove the 'if' if its condition is always true 1303 | __rq_for_each_bio(bio, req) { | ^ include/linux/blk-mq.h:1008:2: note: expanded from macro '__rq_for_each_bio' 1008 | if ((rq->bio)) \ | ^ drivers/block/null_blk/main.c:1287:32: note: initialize the variable 'sector_out' to silence this warning 1287 | sector_t sector_in, sector_out; | ^ | = 0 8 warnings generated. vim +1303 drivers/block/null_blk/main.c 1283 1284 static inline int nullb_setup_copy(struct nullb *nullb, struct request *req, 1285 bool is_fua) 1286 { 1287 sector_t sector_in, sector_out; 1288 loff_t offset_in, offset_out; 1289 void *in, *out; 1290 ssize_t chunk, rem = 0; 1291 struct bio *bio; 1292 struct nullb_page *t_page_in, *t_page_out; 1293 u16 seg = 1; 1294 int status = -EIO; 1295 1296 if (blk_rq_nr_phys_segments(req) != COPY_MAX_SEGMENTS) 1297 return status; 1298 1299 /* 1300 * First bio contains information about source and last bio contains 1301 * information about destination. 1302 */ > 1303 __rq_for_each_bio(bio, req) { 1304 if (seg == blk_rq_nr_phys_segments(req)) { 1305 sector_out = bio->bi_iter.bi_sector; 1306 if (rem != bio->bi_iter.bi_size) 1307 return status; 1308 } else { 1309 sector_in = bio->bi_iter.bi_sector; 1310 rem = bio->bi_iter.bi_size; 1311 } 1312 seg++; 1313 } 1314 1315 trace_nullb_copy_op(req, sector_out << SECTOR_SHIFT, 1316 sector_in << SECTOR_SHIFT, rem); 1317 1318 spin_lock_irq(&nullb->lock); 1319 while (rem > 0) { 1320 chunk = min_t(size_t, nullb->dev->blocksize, rem); 1321 offset_in = (sector_in & SECTOR_MASK) << SECTOR_SHIFT; 1322 offset_out = (sector_out & SECTOR_MASK) << SECTOR_SHIFT; 1323 1324 if (null_cache_active(nullb) && !is_fua) 1325 null_make_cache_space(nullb, PAGE_SIZE); 1326 1327 t_page_in = null_lookup_page(nullb, sector_in, false, 1328 !null_cache_active(nullb)); 1329 if (!t_page_in) 1330 goto err; 1331 t_page_out = null_insert_page(nullb, sector_out, 1332 !null_cache_active(nullb) || 1333 is_fua); 1334 if (!t_page_out) 1335 goto err; 1336 1337 in = kmap_local_page(t_page_in->page); 1338 out = kmap_local_page(t_page_out->page); 1339 1340 memcpy(out + offset_out, in + offset_in, chunk); 1341 kunmap_local(out); 1342 kunmap_local(in); 1343 __set_bit(sector_out & SECTOR_MASK, t_page_out->bitmap); 1344 1345 if (is_fua) 1346 null_free_sector(nullb, sector_out, true); 1347 1348 rem -= chunk; 1349 sector_in += chunk >> SECTOR_SHIFT; 1350 sector_out += chunk >> SECTOR_SHIFT; 1351 } 1352 1353 status = 0; 1354 err: 1355 spin_unlock_irq(&nullb->lock); 1356 return status; 1357 } 1358 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki