Re: [dm-devel] [PATCH v14 01/11] block: Introduce queue limits and sysfs for copy-offload support

Nitesh Shetty
2023-08-14T11:05:03Z

[-- Attachment #1: Type: text/plain, Size: 509 bytes --]

On 23/08/11 02:56PM, Bart Van Assche wrote:
>On 8/11/23 03:52, Nitesh Shetty wrote:
>>+/* maximum copy offload length, this is set to 128MB based on current testing */
>>+#define COPY_MAX_BYTES (1 << 27)
>
>Since the COPY_MAX_BYTES constant is only used in source file
>block/blk-settings.c it should be moved into that file. If you really
>want to keep it in include/linux/blkdev.h, a BLK_ prefix should
>be added.
>
We are using this in other files. So we will add a prefix BLK_.

Thank you,
Nitesh Shetty

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]