Re: [dm-devel] [PATCH v14 01/11] block: Introduce queue limits and sysfs for copy-offload support

Bart Van Assche
2023-08-11T21:56:27Z

On 8/11/23 03:52, Nitesh Shetty wrote:
> +/* maximum copy offload length, this is set to 128MB based on current testing */
> +#define COPY_MAX_BYTES (1 << 27)

Since the COPY_MAX_BYTES constant is only used in source file
block/blk-settings.c it should be moved into that file. If you really
want to keep it in include/linux/blkdev.h, a BLK_ prefix should
be added.

Thanks,

Bart.