Re: [dm-devel] [PATCH v14 03/11] block: add copy offload support

Nitesh Shetty
2023-08-14T11:04:56Z

[-- Attachment #1: Type: text/plain, Size: 372 bytes --]

On 23/08/11 03:06PM, Bart Van Assche wrote:
>On 8/11/23 03:52, Nitesh Shetty wrote:
>>+ if (rem != chunk)
>>+ atomic_inc(&cio->refcount);
>
>This code will be easier to read if the above if-test is left out
>and if the following code is added below the for-loop:
>
> if (atomic_dec_and_test(&cio->refcount))
> blkdev_copy_endio(cio);
>
Acked

Thank you,
Nitesh Shetty

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]