From: Christoph Hellwig <hch@lst.de>
To: Daniel Wagner <dwagner@suse.de>
Cc: Christoph Hellwig <hch@lst.de>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Guangwu Zhang <guazhang@redhat.com>,
Ming Lei <ming.lei@redhat.com>, Keith Busch <kbusch@kernel.org>,
Oleg Solovyov <mcpain@altlinux.org>
Subject: Re: stack smashing detected with 'nvme sanitize-log /dev/nvme0'
Date: Mon, 28 Aug 2023 11:18:50 +0200 [thread overview]
Message-ID: <20230828091850.GA30603@lst.de> (raw)
In-Reply-To: <zopmb3355u2vorlkvas3gqb53azp7qtb7yq2kyc3reezlyqtcy@iev3wkvzumsq>
On Mon, Aug 21, 2023 at 03:37:55PM +0200, Daniel Wagner wrote:
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -1871,7 +1871,6 @@ static void nvme_set_queue_limits(struct nvme_ctrl *ctrl,
> blk_queue_max_segments(q, min_t(u32, max_segments, USHRT_MAX));
> }
> blk_queue_virt_boundary(q, NVME_CTRL_PAGE_SIZE - 1);
> - blk_queue_dma_alignment(q, 3);
> blk_queue_write_cache(q, vwc, vwc);
> }
>
> So what's the best way forward from here? Introduce a quirk and always
> use bounce buffer?
Add a quirk for the device so that we require 512 byte alignment for it.
I suspect the same one will apply to this whole family of buggy MAXIO
devices..
next prev parent reply other threads:[~2023-08-28 9:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 11:52 stack smashing detected with 'nvme sanitize-log /dev/nvme0' Daniel Wagner
2023-07-26 13:16 ` Christoph Hellwig
2023-08-21 13:37 ` Daniel Wagner
2023-08-21 15:11 ` Keith Busch
2023-08-22 7:55 ` Daniel Wagner
2023-08-23 15:37 ` Keith Busch
2023-08-25 6:36 ` Daniel Wagner
2023-08-28 9:21 ` Christoph Hellwig
2023-09-25 15:09 ` Daniel Wagner
2023-09-25 15:19 ` Christoph Hellwig
2023-08-28 9:20 ` Christoph Hellwig
2023-08-29 13:29 ` Keith Busch
2023-08-28 9:18 ` Christoph Hellwig [this message]
2023-07-27 1:30 ` Ming Lei
2023-07-27 1:37 ` Guangwu Zhang
2023-07-27 7:23 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230828091850.GA30603@lst.de \
--to=hch@lst.de \
--cc=dwagner@suse.de \
--cc=guazhang@redhat.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mcpain@altlinux.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).