From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: Sagi Grimberg <sagi@grimberg.me>, Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org, Hannes Reinecke <hare@suse.de>
Subject: [PATCH 1/3] nvme-tcp: Do not terminate commands when in RESETTING
Date: Fri, 8 Sep 2023 12:00:47 +0200 [thread overview]
Message-ID: <20230908100049.80809-2-hare@suse.de> (raw)
In-Reply-To: <20230908100049.80809-1-hare@suse.de>
When the error recovery started it will terminate all commands
anyway, so we should just return BLK_EH_RESET_TIMER for a
command timeout.
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
drivers/nvme/host/tcp.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c
index 5b332d9f87fc..1faef1cf5c94 100644
--- a/drivers/nvme/host/tcp.c
+++ b/drivers/nvme/host/tcp.c
@@ -2274,6 +2274,14 @@ static enum blk_eh_timer_return nvme_tcp_timeout(struct request *rq)
nvme_tcp_queue_id(req->queue), nvme_cid(rq), pdu->hdr.type,
opc, nvme_opcode_str(qid, opc, fctype));
+ /*
+ * If the error recovery is started all commands will be
+ * aborted anyway, and nothing is to be done here.
+ */
+ if (ctrl->state == NVME_CTRL_RESETTING &&
+ work_pending(&to_tcp_ctrl(ctrl)->err_work))
+ return BLK_EH_RESET_TIMER;
+
if (ctrl->state != NVME_CTRL_LIVE) {
/*
* If we are resetting, connecting or deleting we should
--
2.35.3
next prev parent reply other threads:[~2023-09-08 10:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 10:00 [PATCH 0/3] nvme-tcp: start error recovery after KATO Hannes Reinecke
2023-09-08 10:00 ` Hannes Reinecke [this message]
2023-09-12 11:54 ` [PATCH 1/3] nvme-tcp: Do not terminate commands when in RESETTING Sagi Grimberg
2023-09-12 12:06 ` Hannes Reinecke
2023-09-12 12:15 ` Sagi Grimberg
2023-09-12 12:59 ` Hannes Reinecke
2023-09-12 13:02 ` Sagi Grimberg
2023-09-08 10:00 ` [PATCH 2/3] nvme-tcp: make 'err_work' a delayed work Hannes Reinecke
2023-09-08 10:00 ` [PATCH 3/3] nvme-tcp: delay error recovery until the next KATO interval Hannes Reinecke
2023-09-12 12:17 ` Sagi Grimberg
2023-09-12 11:51 ` [PATCH 0/3] nvme-tcp: start error recovery after KATO Sagi Grimberg
2023-09-12 11:56 ` Hannes Reinecke
2023-09-12 12:12 ` Sagi Grimberg
2023-09-12 13:25 ` Hannes Reinecke
2023-09-12 13:43 ` Sagi Grimberg
2023-12-04 10:30 ` Sagi Grimberg
2023-12-04 11:37 ` Hannes Reinecke
2023-12-04 13:27 ` Sagi Grimberg
2023-12-04 14:15 ` Hannes Reinecke
2023-12-04 16:11 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230908100049.80809-2-hare@suse.de \
--to=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox