From: Christoph Hellwig <hch@lst.de>
To: Daniel Wagner <dwagner@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Guangwu Zhang <guazhang@redhat.com>,
Ming Lei <ming.lei@redhat.com>,
Oleg Solovyov <mcpain@altlinux.org>
Subject: Re: stack smashing detected with 'nvme sanitize-log /dev/nvme0'
Date: Mon, 25 Sep 2023 17:19:50 +0200 [thread overview]
Message-ID: <20230925151950.GB444@lst.de> (raw)
In-Reply-To: <fq5ds4d6u7zz3bsag6tj3xdjhodwc25g5nggvalgwmcfovbjma@guuybbch4eja>
On Mon, Sep 25, 2023 at 05:09:16PM +0200, Daniel Wagner wrote:
> > The device just seems completely broken unfortunately.
>
> Just a follow up on this. I've update nvme-cli so that all payloads are
> allocated via the nvme_alloc() helper which ensures that the payloads
> start at a 4k boundary and the buffer is multiple of 4k. This should
> address this issue.
It does not address the issue, it just works around it. I think we
need a kernel level quirk to make sure we never issue commands that
cause these devices to act so broken to them, as the stack smashing is
a security problem.
next prev parent reply other threads:[~2023-09-25 15:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 11:52 stack smashing detected with 'nvme sanitize-log /dev/nvme0' Daniel Wagner
2023-07-26 13:16 ` Christoph Hellwig
2023-08-21 13:37 ` Daniel Wagner
2023-08-21 15:11 ` Keith Busch
2023-08-22 7:55 ` Daniel Wagner
2023-08-23 15:37 ` Keith Busch
2023-08-25 6:36 ` Daniel Wagner
2023-08-28 9:21 ` Christoph Hellwig
2023-09-25 15:09 ` Daniel Wagner
2023-09-25 15:19 ` Christoph Hellwig [this message]
2023-08-28 9:20 ` Christoph Hellwig
2023-08-29 13:29 ` Keith Busch
2023-08-28 9:18 ` Christoph Hellwig
2023-07-27 1:30 ` Ming Lei
2023-07-27 1:37 ` Guangwu Zhang
2023-07-27 7:23 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230925151950.GB444@lst.de \
--to=hch@lst.de \
--cc=dwagner@suse.de \
--cc=guazhang@redhat.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mcpain@altlinux.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).