* [PATCH] nvme-pci: add BOGUS_NID for Intel 0a54 device
@ 2023-10-12 18:29 Keith Busch
2023-10-13 4:31 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Keith Busch @ 2023-10-12 18:29 UTC (permalink / raw)
To: linux-nvme, hch; +Cc: sagi, Keith Busch, welsh
From: Keith Busch <kbusch@kernel.org>
These ones claim cmic and nmic capable, so need special consideration to ignore
their duplicate identifiers.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=217981
Reported-by: welsh@cassens.com
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
drivers/nvme/host/pci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 60a08dfe8d75f..507bc149046dc 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3328,7 +3328,8 @@ static const struct pci_device_id nvme_id_table[] = {
{ PCI_VDEVICE(INTEL, 0x0a54), /* Intel P4500/P4600 */
.driver_data = NVME_QUIRK_STRIPE_SIZE |
NVME_QUIRK_DEALLOCATE_ZEROES |
- NVME_QUIRK_IGNORE_DEV_SUBNQN, },
+ NVME_QUIRK_IGNORE_DEV_SUBNQN |
+ NVME_QUIRK_BOGUS_NID, },
{ PCI_VDEVICE(INTEL, 0x0a55), /* Dell Express Flash P4600 */
.driver_data = NVME_QUIRK_STRIPE_SIZE |
NVME_QUIRK_DEALLOCATE_ZEROES, },
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nvme-pci: add BOGUS_NID for Intel 0a54 device
2023-10-12 18:29 [PATCH] nvme-pci: add BOGUS_NID for Intel 0a54 device Keith Busch
@ 2023-10-13 4:31 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2023-10-13 4:31 UTC (permalink / raw)
To: Keith Busch; +Cc: linux-nvme, hch, sagi, Keith Busch, welsh
On Thu, Oct 12, 2023 at 11:29:34AM -0700, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> These ones claim cmic and nmic capable, so need special consideration to ignore
*sigh*.
The patch looks fine except that the above line should be trimmed a bit.
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-13 4:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-12 18:29 [PATCH] nvme-pci: add BOGUS_NID for Intel 0a54 device Keith Busch
2023-10-13 4:31 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox