From: Christoph Hellwig <hch@lst.de>
To: Kanchan Joshi <joshi.k@samsung.com>
Cc: hch@lst.de, kbusch@kernel.org, axboe@kernel.dk, sagi@grimberg.me,
linux-nvme@lists.infradead.org, joshiiitr@gmail.com,
Anuj Gupta <anuj20.g@samsung.com>
Subject: Re: [PATCH] nvme: fix error-handling for io_uring nvme-passthrough
Date: Wed, 18 Oct 2023 17:50:20 +0200 [thread overview]
Message-ID: <20231018155020.GA26481@lst.de> (raw)
In-Reply-To: <20231018135718.28820-1-joshi.k@samsung.com>
On Wed, Oct 18, 2023 at 07:27:18PM +0530, Kanchan Joshi wrote:
> @@ -508,8 +508,11 @@ static enum rq_end_io_ret nvme_uring_cmd_end_io(struct request *req,
> req->bio = pdu->bio;
> if (nvme_req(req)->flags & NVME_REQ_CANCELLED)
> pdu->nvme_status = -EINTR;
> - else
> + else {
> pdu->nvme_status = nvme_req(req)->status;
> + if (!pdu->nvme_status)
> + pdu->nvme_status = blk_status_to_errno(err);
> + }
Hmm, shoudn't err take precedence over the nvme status?
next prev parent reply other threads:[~2023-10-18 15:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20231018140334epcas5p128c55c56fb9203a19479cbf86175a1d6@epcas5p1.samsung.com>
2023-10-18 13:57 ` [PATCH] nvme: fix error-handling for io_uring nvme-passthrough Kanchan Joshi
2023-10-18 15:50 ` Christoph Hellwig [this message]
2023-10-18 16:50 ` Kanchan Joshi
2023-10-18 16:59 ` Keith Busch
2023-10-18 18:05 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231018155020.GA26481@lst.de \
--to=hch@lst.de \
--cc=anuj20.g@samsung.com \
--cc=axboe@kernel.dk \
--cc=joshi.k@samsung.com \
--cc=joshiiitr@gmail.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox