* [PATCH] nvme-keyring: add MODULE_LICENSE()
@ 2023-10-23 23:00 Randy Dunlap
2023-10-24 5:24 ` Hannes Reinecke
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Randy Dunlap @ 2023-10-23 23:00 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Keith Busch, Jens Axboe, Christoph Hellwig,
Sagi Grimberg, Hannes Reinecke, linux-nvme
When NVME_KEYRING=y (NVME_AUTH is not set), there is a modpost build
error:
ERROR: modpost: missing MODULE_LICENSE() in drivers/nvme/common/nvme-common.o
so add a MODULE_LICENSE() to keyring.c (copied from auth.c).
Fixes: 9d77eb527784 ("nvme-keyring: register '.nvme' keyring")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Keith Busch <kbusch@kernel.org>
Cc: Jens Axboe <axboe@fb.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Sagi Grimberg <sagi@grimberg.me>
Cc: Hannes Reinecke <hare@suse.de>
Cc: linux-nvme@lists.infradead.org
---
drivers/nvme/common/keyring.c | 2 ++
1 file changed, 2 insertions(+)
diff -- a/drivers/nvme/common/keyring.c b/drivers/nvme/common/keyring.c
--- a/drivers/nvme/common/keyring.c
+++ b/drivers/nvme/common/keyring.c
@@ -180,3 +180,5 @@ void nvme_keyring_exit(void)
key_put(nvme_keyring);
}
EXPORT_SYMBOL_GPL(nvme_keyring_exit);
+
+MODULE_LICENSE("GPL v2");
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] nvme-keyring: add MODULE_LICENSE()
2023-10-23 23:00 [PATCH] nvme-keyring: add MODULE_LICENSE() Randy Dunlap
@ 2023-10-24 5:24 ` Hannes Reinecke
2023-10-24 5:56 ` Chaitanya Kulkarni
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Hannes Reinecke @ 2023-10-24 5:24 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel
Cc: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg,
linux-nvme
On 10/24/23 01:00, Randy Dunlap wrote:
> When NVME_KEYRING=y (NVME_AUTH is not set), there is a modpost build
> error:
>
> ERROR: modpost: missing MODULE_LICENSE() in drivers/nvme/common/nvme-common.o
>
> so add a MODULE_LICENSE() to keyring.c (copied from auth.c).
>
> Fixes: 9d77eb527784 ("nvme-keyring: register '.nvme' keyring")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Keith Busch <kbusch@kernel.org>
> Cc: Jens Axboe <axboe@fb.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Sagi Grimberg <sagi@grimberg.me>
> Cc: Hannes Reinecke <hare@suse.de>
> Cc: linux-nvme@lists.infradead.org
> ---
> drivers/nvme/common/keyring.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff -- a/drivers/nvme/common/keyring.c b/drivers/nvme/common/keyring.c
> --- a/drivers/nvme/common/keyring.c
> +++ b/drivers/nvme/common/keyring.c
> @@ -180,3 +180,5 @@ void nvme_keyring_exit(void)
> key_put(nvme_keyring);
> }
> EXPORT_SYMBOL_GPL(nvme_keyring_exit);
> +
> +MODULE_LICENSE("GPL v2");
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew
Myers, Andrew McDonald, Martje Boudien Moerman
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] nvme-keyring: add MODULE_LICENSE()
2023-10-23 23:00 [PATCH] nvme-keyring: add MODULE_LICENSE() Randy Dunlap
2023-10-24 5:24 ` Hannes Reinecke
@ 2023-10-24 5:56 ` Chaitanya Kulkarni
2023-10-24 6:29 ` Christoph Hellwig
2023-11-20 14:40 ` Sagi Grimberg
3 siblings, 0 replies; 5+ messages in thread
From: Chaitanya Kulkarni @ 2023-10-24 5:56 UTC (permalink / raw)
To: linux-nvme@lists.infradead.org
On 10/23/23 16:00, Randy Dunlap wrote:
> When NVME_KEYRING=y (NVME_AUTH is not set), there is a modpost build
> error:
>
> ERROR: modpost: missing MODULE_LICENSE() in drivers/nvme/common/nvme-common.o
>
> so add a MODULE_LICENSE() to keyring.c (copied from auth.c).
>
> Fixes: 9d77eb527784 ("nvme-keyring: register '.nvme' keyring")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Keith Busch <kbusch@kernel.org>
> Cc: Jens Axboe <axboe@fb.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Sagi Grimberg <sagi@grimberg.me>
> Cc: Hannes Reinecke <hare@suse.de>
> Cc: linux-nvme@lists.infradead.org
> ---
> drivers/nvme/common/keyring.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff -- a/drivers/nvme/common/keyring.c b/drivers/nvme/common/keyring.c
> --- a/drivers/nvme/common/keyring.c
> +++ b/drivers/nvme/common/keyring.c
> @@ -180,3 +180,5 @@ void nvme_keyring_exit(void)
> key_put(nvme_keyring);
> }
> EXPORT_SYMBOL_GPL(nvme_keyring_exit);
> +
> +MODULE_LICENSE("GPL v2");
>
do we also need to add author ?
-ck
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] nvme-keyring: add MODULE_LICENSE()
2023-10-23 23:00 [PATCH] nvme-keyring: add MODULE_LICENSE() Randy Dunlap
2023-10-24 5:24 ` Hannes Reinecke
2023-10-24 5:56 ` Chaitanya Kulkarni
@ 2023-10-24 6:29 ` Christoph Hellwig
2023-11-20 14:40 ` Sagi Grimberg
3 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2023-10-24 6:29 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, Keith Busch, Jens Axboe, Christoph Hellwig,
Sagi Grimberg, Hannes Reinecke, linux-nvme
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] nvme-keyring: add MODULE_LICENSE()
2023-10-23 23:00 [PATCH] nvme-keyring: add MODULE_LICENSE() Randy Dunlap
` (2 preceding siblings ...)
2023-10-24 6:29 ` Christoph Hellwig
@ 2023-11-20 14:40 ` Sagi Grimberg
3 siblings, 0 replies; 5+ messages in thread
From: Sagi Grimberg @ 2023-11-20 14:40 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel
Cc: Keith Busch, Jens Axboe, Christoph Hellwig, Hannes Reinecke,
linux-nvme
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-11-20 14:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-23 23:00 [PATCH] nvme-keyring: add MODULE_LICENSE() Randy Dunlap
2023-10-24 5:24 ` Hannes Reinecke
2023-10-24 5:56 ` Chaitanya Kulkarni
2023-10-24 6:29 ` Christoph Hellwig
2023-11-20 14:40 ` Sagi Grimberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox