Re: [PATCH v17 02/20] netlink: add new family to manage ULP_DDP enablement and stats

Jakub Kicinski
2023-10-24T14:59:22Z

On Tue, 24 Oct 2023 15:58:22 +0200 Jiri Pirko wrote:
> >+definitions:
> >+ -
> >+ type: enum
> >+ name: cap
> >+ entries:
> >+ - nvme-tcp
> >+ - nvme-tcp-ddgst-rx
> >+
> >+uapi-header: linux/ulp_ddp_nl.h
>
> Not needed.
> Hmm, Jakub, why this is not only allowed in genetlink-legacy?

Agreed that it's not needed here.
There's a non-trivial chance of name collisions between new families
and existing headers under include/uapi/linux. Since this is a C/C++
-only artifact and "modern" languages will simply ignore it allowing it
seemed like the right choice.

> >+ -
> >+ name: pad
> >+ type: pad
> >+ -
> >+ name: rx-nvmeotcp-sk-add
> >+ doc: Sockets successfully configured for NVMeTCP offloading.
> >+ type: u64

Everything you have as u64 should now be uint, and pads can then go
away.