From: Christoph Hellwig <hch@lst.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Hannes Reinecke <hare@suse.de>, Christoph Hellwig <hch@lst.de>,
Keith Busch <kbusch@kernel.org>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 2/2] nvme: keyring: fix conditional compilation
Date: Thu, 26 Oct 2023 13:58:55 +0200 [thread overview]
Message-ID: <20231026115855.GB3314@lst.de> (raw)
In-Reply-To: <8fad2dc6-3c1a-40c6-8067-ed9bb8ad7532@app.fastmail.com>
On Wed, Oct 25, 2023 at 05:35:12PM +0200, Arnd Bergmann wrote:
> On Wed, Oct 25, 2023, at 17:00, Hannes Reinecke wrote:
> > On 10/25/23 14:16, Arnd Bergmann wrote:
> >> On Wed, Oct 25, 2023, at 11:11, Hannes Reinecke wrote:
> >>> On 10/25/23 10:20, Arnd Bergmann wrote:
> >
> > 'IS_REACHABLE' is the keyword here; if we use that in nvme-keyring.h
> > things are resolved.
> >
> > Will be sending an updated patch.
>
> Please don't use IS_REACHABLE(), it's almost never the right
> solution, even if it avoids this particular build failure,
> it tends to cause hard to debug problems when features that
> are enabled as modules end up not working correctly.
Agreed.
> Another option would be to use Kconfig or Makefile logic
> to force it to be built-in if at least one of the two
> callers is built-in and at least one of them tries to
> use it.
That's the only sensible thing to do, a that is what the user
really wants.
next prev parent reply other threads:[~2023-10-26 11:59 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 8:12 [PATCH 0/2] [v3]: nvme: fixup module compilation Hannes Reinecke
2023-10-25 8:12 ` [PATCH 1/2] nvme: common: make keyring and auth separate modules Hannes Reinecke
2023-10-26 11:50 ` Christoph Hellwig
2023-10-25 8:12 ` [PATCH 2/2] nvme: keyring: fix conditional compilation Hannes Reinecke
2023-10-25 8:20 ` Arnd Bergmann
2023-10-25 9:11 ` Hannes Reinecke
2023-10-25 12:16 ` Arnd Bergmann
2023-10-25 15:00 ` Hannes Reinecke
2023-10-25 15:35 ` Arnd Bergmann
2023-10-26 11:58 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-10-26 13:08 [PATCH 0/2] [v4] nvme: fixup module compilation Hannes Reinecke
2023-10-26 13:08 ` [PATCH 2/2] nvme: keyring: fix conditional compilation Hannes Reinecke
2023-10-26 13:37 ` Arnd Bergmann
2023-10-26 14:20 ` Hannes Reinecke
2023-10-26 14:44 ` Arnd Bergmann
2023-10-27 5:21 ` Christoph Hellwig
2023-10-27 6:01 ` Hannes Reinecke
2023-10-27 8:12 ` Arnd Bergmann
2023-10-27 8:30 ` Christoph Hellwig
2023-10-27 8:54 ` Hannes Reinecke
2023-10-27 8:56 ` Christoph Hellwig
2023-10-27 9:08 ` Hannes Reinecke
2023-10-27 9:14 ` Arnd Bergmann
2023-10-27 9:21 ` Christoph Hellwig
2023-11-07 17:49 ` Keith Busch
2023-10-20 13:05 [PATCH 1/2] nvme: common: make keyring and auth separate modules Arnd Bergmann
2023-10-20 13:05 ` [PATCH 2/2] nvme: keyring: fix conditional compilation Arnd Bergmann
2023-10-20 13:50 ` Hannes Reinecke
2023-10-20 14:56 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231026115855.GB3314@lst.de \
--to=hch@lst.de \
--cc=arnd@arndb.de \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox