From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6478AC4167D for ; Wed, 1 Nov 2023 11:45:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=Y4qWGKy+pZQgc4neiYZ4RrQ6V3aKkuJqNqueZsPc9Fk=; b=hv9nxu98wh8KPU 3sDrCl4fTw5wDBImJi/P71v7H64s4jLpDv5D0mETzv3Ekepw3gPy01Z0kVpJAFUX2lA/Cgfw8A3uN F8lsY1Sg0HQgYp0FHFkUCJHM+sSx7Pu3D3bxerq3Ylblk7hCq9CKb0Wd1KlFn8EshJga50AkBnmI8 6bPtMP72JppX95l4zHO5Fm/aCggbp03/XNDTkRU5LAGaUOg3kAhdm/dHvXtulqP04MidvjAIm+yxx +5yf59OgOYGBjh9XdSrI6k5V9pBLuwdHLLNU9A3641l6hGtXxnT6Z9VpL2nF7iMg3L8pG63EYagMb RxdJlbj3Rrx5WlwXxp9A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qy9fO-007I2K-0e; Wed, 01 Nov 2023 11:45:46 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qy9fL-007I1h-35 for linux-nvme@lists.infradead.org; Wed, 01 Nov 2023 11:45:45 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7A2C5611CE; Wed, 1 Nov 2023 11:45:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F09E1C433C7; Wed, 1 Nov 2023 11:45:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698839143; bh=uRdXVaNPSlmlco16plmQ5T/iCvBKB01tajwUhNVdG/g=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=RPoaNCBh+5fWMFs+UXqnfKgZH7T4yKQK6DTDbUkzeIY5Wt0e1UVOXzqawPZnLhVxl dFmYdGqgRQZDNKi8x2I4n1FnaR3qFsPSHO1Rwqrz8AbK/t/1mbqRXJLPIvMj1Ctmp1 PG8bon32+33rlzgcCY6y3ZdQGNRmCtyMlowB56lJ+oMeOUBQZHjkiJRvd7h5Zqbkik 6lTjUGPSERr1/WzpjN+In6K8tIBIfXBTE/NFbRZaOfzDoamWJCpJvGaN3N651KcICo UEytFq27OCxmWI0OUmPMZOF4jB883M7OfExPK/5Cr/sLru00NZICixp6lpb6SHDlaY 6SeEXPqji8vvg== Date: Wed, 1 Nov 2023 06:45:41 -0500 From: Bjorn Helgaas To: Bagas Sanjaya Cc: Linux Kernel Mailing List , Linux Regressions , Linux NVMe , linux-pci@vger.kernel.org, Bjorn Helgaas , Chaitanya Kulkarni , Christoph Hellwig , gloriouseggroll@gmail.com Subject: Re: Fwd: Regression: Kernel 6.4 rc1 and higher causes Steam Deck to fail to wake from suspend (bisected) Message-ID: <20231101114541.GA43502@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0e784280-02bb-4e0e-a5ae-4e0a40ea4c51@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231101_044544_078684_A288C444 X-CRM114-Status: GOOD ( 24.55 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org [+cc linux-pci] On Tue, Oct 31, 2023 at 03:21:20PM +0700, Bagas Sanjaya wrote: > Hi, > > I notice a regression report on Bugzilla [1]. Quoting from it: > > > On Kernel 6.4 rc1 and higher if you put the Steam Deck into suspend then press the power button again it will not wake up. > > > > I don't have a clue as to -why- this commit breaks wake from suspend on steam deck, but it does. Bisected to: > > > > ``` > > 1ad11eafc63ac16e667853bee4273879226d2d1b is the first bad commit > > commit 1ad11eafc63ac16e667853bee4273879226d2d1b > > Author: Bjorn Helgaas > > Date: Tue Mar 7 14:32:43 2023 -0600 > > > > nvme-pci: drop redundant pci_enable_pcie_error_reporting() > > > > pci_enable_pcie_error_reporting() enables the device to send ERR_* > > Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is > > native"), the PCI core does this for all devices during enumeration, so the > > driver doesn't need to do it itself. > > > > Remove the redundant pci_enable_pcie_error_reporting() call from the > > driver. Also remove the corresponding pci_disable_pcie_error_reporting() > > from the driver .remove() path. > > > > Note that this only controls ERR_* Messages from the device. An ERR_* > > Message may cause the Root Port to generate an interrupt, depending on the > > AER Root Error Command register managed by the AER service driver. > > > > Signed-off-by: Bjorn Helgaas > > Reviewed-by: Chaitanya Kulkarni > > Signed-off-by: Christoph Hellwig > > > > drivers/nvme/host/pci.c | 6 +----- > > 1 file changed, 1 insertion(+), 5 deletions(-) > > ``` > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-6.4.y&id=1ad11eafc63ac16e667853bee4273879226d2d1b > > > > Reverting that commit by itself on top of 6.5.9 (stable) allows it to wake from suspend properly. > > See Bugzilla for the full thread. > > Anyway, I'm adding this regression to regzbot: > > #regression introduced: 1ad11eafc63ac1 https://bugzilla.kernel.org/show_bug.cgi?id=218090 > #regression title: Steam Deck fails to wake from suspend due to pci_enable_pcie_error_reporting() removal > > Thanks. > > [1]: https://bugzilla.kernel.org/show_bug.cgi?id=218090 Thanks, I requested some dmesg logs and lspci output to help debug this.