From: Christoph Hellwig <hch@lst.de>
To: Daniel Wagner <dwagner@suse.de>
Cc: Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@lst.de>,
Niklas Cassel <Niklas.Cassel@wdc.com>,
Kenji Tomonaga <tkenbo@gmail.com>
Subject: Re: [PATCH v3] nvme: update firmware version after commit
Date: Fri, 3 Nov 2023 14:58:57 +0100 [thread overview]
Message-ID: <20231103135857.GA1871@lst.de> (raw)
In-Reply-To: <y32ounthrv2uuedtriy73oir5m7k5ryupzytd2x5wn436bcrj7@7xalhdepjyk6>
On Fri, Nov 03, 2023 at 01:11:02PM +0100, Daniel Wagner wrote:
> This particular firmware seem to interpret afi one based, while
> the this patch assumes it is zero based
> Active Firmware Info (AFI): Specifies information about the active
> firmware revision.
>
> Bit 7 is reserved.
> Bits 6:4 indicates the firmware slot that is going to be activated
> at the next Controller Level Reset. If this field is 0h,
> then the controller does not indicate the firmware slot that
> is going to be activated at the next Controller Level Reset.
> Bit 3 is reserved.
> Bits 2:0 indicates the firmware slot from which the actively running
> firmware revision was loaded.
>
>
> It's not clear to me if afi bits 2:0 is zero or one based. Bits 6:4
> indicate to be 1 based.
All 0's based (what a stupid term..) fields in NVMe are explicitly
marked as such. And even if that wasn't the case I'd very much
expect the same encoding for the two sub-fields.
next prev parent reply other threads:[~2023-11-03 13:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 16:00 [PATCH v3] nvme: update firmware version after commit Daniel Wagner
2023-10-31 8:53 ` Christoph Hellwig
2023-10-31 14:20 ` Niklas Cassel
2023-10-31 16:08 ` Daniel Wagner
2023-10-31 16:08 ` Keith Busch
2023-11-03 12:11 ` Daniel Wagner
2023-11-03 13:58 ` Christoph Hellwig [this message]
2023-11-03 14:22 ` Keith Busch
2023-11-06 7:00 ` Daniel Wagner
2023-11-06 16:44 ` Keith Busch
2023-11-07 8:30 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231103135857.GA1871@lst.de \
--to=hch@lst.de \
--cc=Niklas.Cassel@wdc.com \
--cc=dwagner@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=tkenbo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox