From: Keith Busch <kbusch@meta.com>
To: <linux-nvme@lists.infradead.org>
Cc: <hch@lst.de>, <hare@suse.de>, <rnd@arndb.de>,
Keith Busch <kbusch@kernel.org>
Subject: [PATCHv5 0/2] nvme: fixup module compilation
Date: Tue, 7 Nov 2023 10:14:19 -0800 [thread overview]
Message-ID: <20231107181421.593353-1-kbusch@meta.com> (raw)
From: Keith Busch <kbusch@kernel.org>
Trying to sort this out before rc1, here's my take on bringing this
together after reading through the history on it.
Changes from previous version:
I updated patch one's keyring stub check to use IS_ENABLED rather than
ifdef. The patch makes CONFIG_NVME_SYMBOL possible to be a module now,
so ifdef doesn't work correctly with that.
For patch 2, I removed all the Kconfig stuff from the previous,
otherwise it's the same. nvme-keyring will not be built-in unless a
dependency is also built-in, otherwise it will be a module if another
module depends on it.
Arnd Bergmann (1):
nvme: common: make keyring and auth separate modules
Hannes Reinecke (1):
nvme: keyring: fix conditional compilation
drivers/nvme/Makefile | 2 +-
drivers/nvme/common/Kconfig | 7 ++-----
drivers/nvme/common/Makefile | 7 ++++---
drivers/nvme/common/keyring.c | 11 +++++++----
drivers/nvme/host/Kconfig | 2 --
drivers/nvme/host/core.c | 9 +--------
drivers/nvme/target/Kconfig | 2 --
include/linux/nvme-keyring.h | 10 +---------
8 files changed, 16 insertions(+), 34 deletions(-)
--
2.34.1
next reply other threads:[~2023-11-07 18:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 18:14 Keith Busch [this message]
2023-11-07 18:14 ` [PATCHv3 1/2] nvme: common: make keyring and auth separate modules Keith Busch
2023-11-08 7:09 ` Christoph Hellwig
2023-11-07 18:14 ` [PATCHv3 2/2] nvme: keyring: fix conditional compilation Keith Busch
2023-11-08 7:11 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231107181421.593353-1-kbusch@meta.com \
--to=kbusch@meta.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=rnd@arndb.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox