From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E1F4C4167D for ; Tue, 7 Nov 2023 21:25:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IUlUmj/GndXSoV12Fn4r90IKhOFf3p5hWYhXGUfxEjU=; b=Zk3iIouYA0qmZir1/k/uzYc9Dz t0BhQBXeuOIBEp6keIVmQ9GnZKsMWNVmit7o725AjgeUuZE9+JWF5ZVWAy6qD6x2CVpi2+1KscyR9 ZdueNU/o83q8emP/0WKtGLLld9JoGyZpGtAIILWBQnF9pEFGBcB8I0Iuv09/Vkkq1woeKWP26SGj9 5PUbQeOkqOoqy7SRsEPKvqLTVL7bjqDE+ULcpLjPzqNc1rZEa3quNaCqmdbMu9E4kC0efr49dIGRl ynkNnw/ko+2pR8ddCk4Nh43m0tg+j4meKdi+Mg9BT5A0DYyY8MgWwQuLmC5kNG1r0uRjswNvGmFph g+9OdWjg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r0TZV-002QSX-2Q; Tue, 07 Nov 2023 21:25:17 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r0TZS-002QRo-1g for linux-nvme@lists.infradead.org; Tue, 07 Nov 2023 21:25:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699392313; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IUlUmj/GndXSoV12Fn4r90IKhOFf3p5hWYhXGUfxEjU=; b=FnEDWF0LxmUVJyEULiH/S4519a8mqo9C7UMbeolZM/mozgHUZv77LedNsKaFCNvCERdoCW ZsvIRW7vwDmnKMXCgk7kir1i4EhI4AkoM60oU/eFZe45L+3nDa2//2tdbyYjNmv52MoqPx MVNrXa8gzW2jaoFC3gT+/gO+svD+xXM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-42-MZl4okXxMQmV2vGUOkvPbg-1; Tue, 07 Nov 2023 16:23:32 -0500 X-MC-Unique: MZl4okXxMQmV2vGUOkvPbg-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7A04285A5B5; Tue, 7 Nov 2023 21:23:32 +0000 (UTC) Received: from emilne.bos.redhat.com (unknown [10.18.25.205]) by smtp.corp.redhat.com (Postfix) with ESMTP id 629CC492BE7; Tue, 7 Nov 2023 21:23:32 +0000 (UTC) From: "Ewan D. Milne" To: linux-nvme@lists.infradead.org Cc: tsong@purestorage.com Subject: [PATCH 3/3] nvme: multipath: Invalidate current_path when changing iopolicy Date: Tue, 7 Nov 2023 16:23:31 -0500 Message-Id: <20231107212331.9413-3-emilne@redhat.com> In-Reply-To: <20231107212331.9413-1-emilne@redhat.com> References: <20231107212331.9413-1-emilne@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231107_132514_625849_72F176A2 X-CRM114-Status: UNSURE ( 8.78 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org When switching back to numa from round-robin, current_path may refer to a different path than the one numa would have selected, and it is desirable to have consistent behavior. Signed-off-by: Ewan D. Milne --- drivers/nvme/host/multipath.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c index e184e7c377bc..273940b6ca86 100644 --- a/drivers/nvme/host/multipath.c +++ b/drivers/nvme/host/multipath.c @@ -859,6 +859,7 @@ void nvme_subsys_iopolicy_update(struct nvme_subsystem *subsys, int iopolicy) mutex_lock(&nvme_subsystems_lock); list_for_each_entry(ctrl, &subsys->ctrls, subsys_entry) { atomic_set(&ctrl->nr_active, 0); + nvme_mpath_clear_ctrl_paths(ctrl); } mutex_unlock(&nvme_subsystems_lock); } -- 2.20.1