From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@meta.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de, hare@suse.de,
rnd@arndb.de, Arnd Bergmann <arnd@arndb.de>,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCHv3 1/2] nvme: common: make keyring and auth separate modules
Date: Wed, 8 Nov 2023 08:09:22 +0100 [thread overview]
Message-ID: <20231108070922.GB4684@lst.de> (raw)
In-Reply-To: <20231107181421.593353-2-kbusch@meta.com>
On Tue, Nov 07, 2023 at 10:14:20AM -0800, Keith Busch wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When only the keyring module is included but auth is not, modpost
> complains about the lack of a module license tag:
>
> ERROR: modpost: missing MODULE_LICENSE() in drivers/nvme/common/nvme-common.o
>
> Address this by making both modules buildable standalone,
> removing the now unnecessary CONFIG_NVME_COMMON symbol
> in the process.
>
> Also, now that NVME_KEYRING config symbol can be either a module or
> built-in, the stubs need to check for '#if IS_ENABLED' rather than a
> simple '#ifdef'.
I know I reviewed this before, but after the whole discussion this
splitting seems rather pointless. All that we need for a minimal
fix would be to create a new file containing nothing but the
MODULE_LICENSE statement so that it is always built. And these
two modules would be really tiny and wasteful.
next prev parent reply other threads:[~2023-11-08 7:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 18:14 [PATCHv5 0/2] nvme: fixup module compilation Keith Busch
2023-11-07 18:14 ` [PATCHv3 1/2] nvme: common: make keyring and auth separate modules Keith Busch
2023-11-08 7:09 ` Christoph Hellwig [this message]
2023-11-07 18:14 ` [PATCHv3 2/2] nvme: keyring: fix conditional compilation Keith Busch
2023-11-08 7:11 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231108070922.GB4684@lst.de \
--to=hch@lst.de \
--cc=arnd@arndb.de \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=rnd@arndb.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox