From: Keith Busch <kbusch@meta.com>
To: <linux-block@vger.kernel.org>, <linux-nvme@lists.infradead.org>,
<io-uring@vger.kernel.org>
Cc: <axboe@kernel.dk>, <hch@lst.de>, <joshi.k@samsung.com>,
<martin.petersen@oracle.com>, <ming.lei@redhat.com>,
Keith Busch <kbusch@kernel.org>
Subject: [PATCHv4 4/4] io_uring: remove uring_cmd cookie
Date: Tue, 28 Nov 2023 14:27:52 -0800 [thread overview]
Message-ID: <20231128222752.1767344-5-kbusch@meta.com> (raw)
In-Reply-To: <20231128222752.1767344-1-kbusch@meta.com>
From: Keith Busch <kbusch@kernel.org>
No more users of this field.
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
include/linux/io_uring.h | 8 ++------
io_uring/uring_cmd.c | 1 -
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/include/linux/io_uring.h b/include/linux/io_uring.h
index fe23bf88f86fa..9e6ce6d4ab51f 100644
--- a/include/linux/io_uring.h
+++ b/include/linux/io_uring.h
@@ -32,12 +32,8 @@ enum io_uring_cmd_flags {
struct io_uring_cmd {
struct file *file;
const struct io_uring_sqe *sqe;
- union {
- /* callback to defer completions to task context */
- void (*task_work_cb)(struct io_uring_cmd *cmd, unsigned);
- /* used for polled completion */
- void *cookie;
- };
+ /* callback to defer completions to task context */
+ void (*task_work_cb)(struct io_uring_cmd *cmd, unsigned);
u32 cmd_op;
u32 flags;
u8 pdu[32]; /* available inline for free use */
diff --git a/io_uring/uring_cmd.c b/io_uring/uring_cmd.c
index acbc2924ecd21..b39ec25c36bc3 100644
--- a/io_uring/uring_cmd.c
+++ b/io_uring/uring_cmd.c
@@ -182,7 +182,6 @@ int io_uring_cmd(struct io_kiocb *req, unsigned int issue_flags)
return -EOPNOTSUPP;
issue_flags |= IO_URING_F_IOPOLL;
req->iopoll_completed = 0;
- WRITE_ONCE(ioucmd->cookie, NULL);
}
ret = file->f_op->uring_cmd(ioucmd, issue_flags);
--
2.34.1
next prev parent reply other threads:[~2023-11-28 22:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 22:27 [PATCHv4 0/4] block integrity: directly map user space addresses Keith Busch
2023-11-28 22:27 ` [PATCHv4 1/4] block: bio-integrity: directly map user buffers Keith Busch
2023-11-29 15:18 ` Kanchan Joshi
2023-11-29 16:35 ` Keith Busch
2023-11-28 22:27 ` [PATCHv4 2/4] nvme: use bio_integrity_map_user Keith Busch
2023-11-28 22:27 ` [PATCHv4 3/4] iouring: remove IORING_URING_CMD_POLLED Keith Busch
2023-11-28 22:27 ` Keith Busch [this message]
2023-11-29 1:37 ` [PATCHv4 0/4] block integrity: directly map user space addresses Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231128222752.1767344-5-kbusch@meta.com \
--to=kbusch@meta.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=io-uring@vger.kernel.org \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox