From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@meta.com>,
linux-nvme@lists.infradead.org, sagi@grimberg.me,
axboe@kernel.dk
Subject: Re: [PATCH] nvme-ioctl: move capable() admin check to the end
Date: Mon, 4 Dec 2023 15:35:52 +0100 [thread overview]
Message-ID: <20231204143552.GA30918@lst.de> (raw)
In-Reply-To: <ZW3jHePnYN_m7OU7@kbusch-mbp>
On Mon, Dec 04, 2023 at 07:33:01AM -0700, Keith Busch wrote:
> On Mon, Dec 04, 2023 at 09:30:34AM +0100, Christoph Hellwig wrote:
> > On Thu, Nov 30, 2023 at 12:19:19PM -0800, Keith Busch wrote:
> > > From: Keith Busch <kbusch@kernel.org>
> > >
> > > This can be an expensive call on some distros.
> >
> > Huh? How would a distro matter for kernel code?
>
> Security monitoring: audit, LSM, and bpf hooks all make this function
> undesirable for a fast path check.
So what matters is kernel configuration, not "distro".
next prev parent reply other threads:[~2023-12-04 14:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 20:19 [PATCH] nvme-ioctl: move capable() admin check to the end Keith Busch
2023-11-30 23:09 ` Jens Axboe
2023-12-04 8:17 ` Sagi Grimberg
2023-12-04 8:30 ` Christoph Hellwig
2023-12-04 14:33 ` Keith Busch
2023-12-04 14:35 ` Christoph Hellwig [this message]
2023-12-04 15:42 ` Keith Busch
2023-12-04 15:45 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231204143552.GA30918@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox