From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B463C4167B for ; Mon, 4 Dec 2023 15:45:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=X34MQO2rh60nwYgEVMOQO3K6THz4KRv53puDWKyM13g=; b=fo/gRaR9npw7dsqviTVZiAQgGH Zk+AiTFfvAqSsXB1hOu7lo53NtdmlxgH3lj0Ll3OZxXDjdKGAM73dd+Cfn2t4tQVsBVGKLbgwMojB kPoQfcDx2MSqLSiozwzCdvx/rkcVyvbO+p0+KpKbIs0JVwPL4GvPTseuf/k+8tmvCfdQ2raSiuJA9 /03CU2YCcZcmRsfz8RlpRjBjosykU3xs69a08rTCo3hofGm7s+Xf+gm/fhJhjQrezu6HFdjMAzGjm 8NiGUKrUI5v7ef+hQuVvgIw5pPNj/S0R7d1HKan4MUhCfKzK9nyO1qIk6Oby8G2smfnaaU7UzN/Kq EIVFSssQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rAB8n-0050Em-2y; Mon, 04 Dec 2023 15:45:49 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rAB8k-0050De-37 for linux-nvme@lists.infradead.org; Mon, 04 Dec 2023 15:45:48 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id B0974227A8E; Mon, 4 Dec 2023 16:45:41 +0100 (CET) Date: Mon, 4 Dec 2023 16:45:41 +0100 From: Christoph Hellwig To: Keith Busch Cc: Christoph Hellwig , Keith Busch , linux-nvme@lists.infradead.org, sagi@grimberg.me, axboe@kernel.dk Subject: Re: [PATCH] nvme-ioctl: move capable() admin check to the end Message-ID: <20231204154541.GA4287@lst.de> References: <20231130201919.2486553-1-kbusch@meta.com> <20231204083034.GA32360@lst.de> <20231204143552.GA30918@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231204_074547_145712_5D7C775C X-CRM114-Status: GOOD ( 12.18 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Mon, Dec 04, 2023 at 08:42:55AM -0700, Keith Busch wrote: > Yeah, fair enough: the overhead comes from the kernel config. So just > update the change log and good to go? Yes, with that: Reviewed-by: Christoph Hellwig