From: hare@kernel.org
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org, Hannes Reinecke <hare@suse.de>
Subject: [PATCHv3 0/2] nvmet: avoid circular locking warning
Date: Fri, 8 Dec 2023 13:53:19 +0100 [thread overview]
Message-ID: <20231208125321.165819-1-hare@kernel.org> (raw)
From: Hannes Reinecke <hare@suse.de>
nvmet-rdma and nvmet-tcp trigger a circular locking warning when
tearing down; reason is a call to 'flush_workqueue' when creating
a new controller which tries to cover for the fact that old controller
instances might be in the process of tearing down.
However, this is pure speculation as we don't know (and don't check)
if there really _are_ controllers in shutdown.
And even if there were, that should be short-lived, and would have been
resolved by connecting just a tad later.
So this patch returns 'controller busy' if we really find ourselves in this
situation, allowing the caller to reconnect later.
Changes to v2:
- Implement backlog as suggested by Sagi
Changes to the original version:
- Update the rdma patch to implement 'install_queue()'
- Include suggestions from Jens Axboe
Hannes Reinecke (2):
nvmet-tcp: avoid circular locking dependency on install_queue()
nvmet-rdma: avoid circular locking dependency on install_queue()
drivers/nvme/target/rdma.c | 19 ++++++++++++++++---
drivers/nvme/target/tcp.c | 18 +++++++++++++++---
2 files changed, 31 insertions(+), 6 deletions(-)
--
2.35.3
next reply other threads:[~2023-12-08 12:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 12:53 hare [this message]
2023-12-08 12:53 ` [PATCH 1/2] nvmet-tcp: avoid circular locking dependency on install_queue() hare
2023-12-11 14:10 ` Sagi Grimberg
2023-12-08 12:53 ` [PATCH 2/2] nvmet-rdma: " hare
2023-12-11 14:10 ` Sagi Grimberg
[not found] ` <3eefcbfd-a93f-4c1c-957a-66058e5cdb54@nvidia.com>
2024-06-03 6:43 ` Sagi Grimberg
2023-12-11 12:44 ` [PATCHv3 0/2] nvmet: avoid circular locking warning Shinichiro Kawasaki
2024-01-10 4:12 ` Shinichiro Kawasaki
2024-01-10 21:38 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231208125321.165819-1-hare@kernel.org \
--to=hare@kernel.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox