Re: [PATCH v21 06/20] nvme-tcp: Add DDP data-path

Max Gurtovoy
2023-12-18T18:47:39Z

On 18/12/2023 20:08, Aurelien Aptel wrote:
> Max Gurtovoy <mgurtovoy@nvidia.com> writes:
>>> +
>>> + if (nvme_tcp_is_ddp_offloaded(req)) {
>>
>> Same optimization here:
>>
>> if (IS_ENABLED(CONFIG_ULP_DDP) && nvme_tcp_is_ddp_offloaded(req)) {
>>
>
> nvme_tcp_is_ddp_offloaded() compiles to "return false" when ULP_DDP is
> disabled and the compiler already folds the branching completely.
>
>>
>> if (IS_ENABLED(CONFIG_ULP_DDP) && test_bit(NVME_TCP_Q_OFF_DDP,
>> &queue->flags))
>>
>
> Same, I've checked and the test is already optimized out.
>
> Thanks
>

Ok looks good,

Reviewed-by: Max Gurtovoy <mgurtovoy@nvidia.com>