From: Christoph Hellwig <hch@lst.de>
To: Guixin Liu <kanie@linux.alibaba.com>
Cc: james.smart@broadcom.com, kbusch@kernel.org, axboe@kernel.dk,
hch@lst.de, sagi@grimberg.me, linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: validate maxcmd before use it
Date: Mon, 18 Dec 2023 06:56:28 +0100 [thread overview]
Message-ID: <20231218055628.GA16928@lst.de> (raw)
In-Reply-To: <1702629808-96718-1-git-send-email-kanie@linux.alibaba.com>
On Fri, Dec 15, 2023 at 04:43:28PM +0800, Guixin Liu wrote:
> According to the NVMe specification, if the 'maximum outstanding
> commands' (maxcmd) field is not utilized, it must be set to 0h.
> When a host connects to a target that does not employ the maxcmd
> field, the queue size (sqsize) gets set to an excessively large
> value due to the calculation (u16)(0 - 1) = 65535.
> As a result, such a misconfiguration leads to the failure of the
> connection establishment.
MAXCMD is mandatory for Fabrics.
next prev parent reply other threads:[~2023-12-18 5:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 8:43 [PATCH] nvme: validate maxcmd before use it Guixin Liu
2023-12-15 12:30 ` Hannes Reinecke
2023-12-18 5:56 ` Christoph Hellwig [this message]
2023-12-18 8:04 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231218055628.GA16928@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=james.smart@broadcom.com \
--cc=kanie@linux.alibaba.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox