Re: [PATCH v3 01/16] nvmet: report ioccsz and iorcsz for disc ctrl

Max Gurtovoy
2023-12-20T00:50:55Z

On 19/12/2023 6:27, Christoph Hellwig wrote:
> On Mon, Dec 18, 2023 at 04:30:49PM +0100, Daniel Wagner wrote:
>> + /*
>> + * Max command capsule size is sqe + in-capsule data size.
>> + * Disable in-capsule data for Metadata capable controllers.
>
> A why on the disable would be useful here - the fact that it is disabled
> is pretty obvious from the code.
>

We have another thread on this patch that I think is wrong since the
discovery controller shouldn't set these values according to the spec.
It is explicitly say that ioccsz and iorcsz are reserved for discovery
controllers.

I've sent a proposal to fix the initiator/host code.