Re: [PATCH v3 03/16] nvmet-trace: avoid dereferencing pointer too early

Christoph Hellwig
2023-12-19T04:29:31Z

On Mon, Dec 18, 2023 at 04:30:51PM +0100, Daniel Wagner wrote:
> #ifndef TRACE_HEADER_MULTI_READ
> -static inline struct nvmet_ctrl *nvmet_req_to_ctrl(struct nvmet_req *req)
> +static inline u16 nvmet_req_to_ctrl_id(struct nvmet_req *req)
> {
> - return req->sq->ctrl;
> + /*
> + * The queue and controller pointer are not valid until an association
> + * has been established.

s/pointer/pointers/ ?

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>