Re: [PATCH v3 07/16] nvmet-fc: Release reference on target port

Christoph Hellwig
2023-12-19T04:36:25Z

On Mon, Dec 18, 2023 at 04:30:55PM +0100, Daniel Wagner wrote:
> @@ -360,6 +360,7 @@ __nvmet_fc_finish_ls_req(struct nvmet_fc_ls_req_op *lsop)
>
> if (!lsop->req_queued) {
> spin_unlock_irqrestore(&tgtport->lock, flags);
> + nvmet_fc_tgtport_put(tgtport);
> return;

Adding an out_put label and jumping to it would be nice here to keep
the cleanup path common.