From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@meta.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de, sagi@grimberg.me,
axboe@kernel.dk, chaitanyak@nvidia.com,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCHv2] nvme-pci: enhance timeout kernel log
Date: Tue, 19 Dec 2023 06:01:08 +0100 [thread overview]
Message-ID: <20231219050108.GA31771@lst.de> (raw)
In-Reply-To: <20231218224633.2963811-1-kbusch@meta.com>
On Mon, Dec 18, 2023 at 02:46:33PM -0800, Keith Busch wrote:
> - "I/O %d QID %d timeout, completion polled\n",
> + "I/O tag %d QID %d timeout, completion polled\n",
Q: should we use the Linux term tag or the NVMe term command ID
(or command_id) ? I don't really care, just thinking out loud.
> + opcode = nvme_req(req)->cmd->common.opcode;
> if (!nvmeq->qid || iod->aborted) {
> dev_warn(dev->ctrl.device,
> - "I/O %d QID %d timeout, reset controller\n",
> - req->tag, nvmeq->qid);
> + "I/O tag %d (opcode:%s %d) QID %d timeout, reset controller\n",
> + req->tag, nvme_opcode_str(nvmeq->qid, opcode, 0),
> + opcode, nvmeq->qid);
space after the ":" ?
> + "I/O tag %d (opcode:%s %d) QID %d timeout, aborting req_op:%s(%u) size:%u\n",
> + req->tag, nvme_get_opcode_str(opcode), opcode, nvmeq->qid,
> + blk_op_str(req_op(req)), req_op(req), blk_rq_bytes(req));
Same.
next prev parent reply other threads:[~2023-12-19 5:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 22:46 [PATCHv2] nvme-pci: enhance timeout kernel log Keith Busch
2023-12-19 5:01 ` Christoph Hellwig [this message]
2023-12-19 14:15 ` Sagi Grimberg
2023-12-19 16:09 ` Max Gurtovoy
2023-12-19 16:15 ` Keith Busch
2023-12-19 16:21 ` Max Gurtovoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231219050108.GA31771@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=chaitanyak@nvidia.com \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox