From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@meta.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de, hare@suse.de,
sagi@grimberg.me, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH] nvme-auth: isolate auth to fabrics transports
Date: Tue, 19 Dec 2023 06:03:10 +0100 [thread overview]
Message-ID: <20231219050310.GB31771@lst.de> (raw)
In-Reply-To: <20231218221613.2803017-1-kbusch@meta.com>
On Mon, Dec 18, 2023 at 02:16:13PM -0800, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> Some transports don't use authentication, so contain the resources and
> handling for it to fabrics that do use it.
Is it really worth to have a separate structure for those relatively few
fields? If so it might make sense to just have a nvme_fabrics_ctrl
structure that wraps struct nvme_ctrl.
And a somewhat more descriptive commit log would also be useful.
prev parent reply other threads:[~2023-12-19 5:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 22:16 [PATCH] nvme-auth: isolate auth to fabrics transports Keith Busch
2023-12-19 5:03 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231219050310.GB31771@lst.de \
--to=hch@lst.de \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox