Re: [PATCH v2 01/16] block: Add atomic write operations to request_queue limits

Christoph Hellwig
2023-12-14T16:12:33Z

On Wed, Dec 13, 2023 at 09:25:38AM +0800, Ming Lei wrote:

<full quote deleted, please only quote what is relevant.

> > lim->dma_alignment = 511;
> > + lim->atomic_write_unit_min_sectors = 0;
> > + lim->atomic_write_unit_max_sectors = 0;
> > + lim->atomic_write_max_sectors = 0;
> > + lim->atomic_write_boundary_sectors = 0;
>
> Can we move the four into single structure and setup them in single
> API? Then cross-validation can be done in this API.

Please don't be arbitrarily different from all the other limits. What
we really should be doing is an API that updates all limits at the
same time, and I actually have code for that, I'll just need to finish
it. I do not want to block this series for it, though.