From: Christoph Hellwig <hch@lst.de>
To: Guixin Liu <kanie@linux.alibaba.com>
Cc: kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH V3] nvme: introduce nvme_disk_is_ns_head helper
Date: Thu, 28 Dec 2023 07:17:16 +0100 [thread overview]
Message-ID: <20231228061716.GA12379@lst.de> (raw)
In-Reply-To: <20231227093106.78551-1-kanie@linux.alibaba.com>
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
> + if (nvme_disk_is_ns_head(disk))
> return disk->private_data;
> + else
> + return nvme_get_ns_from_dev(dev)->head;
> }
Keith, maybe you can drop the superflous (pre-existing) else here when
applying.
next prev parent reply other threads:[~2023-12-28 6:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-27 9:31 [PATCH V3] nvme: introduce nvme_disk_is_ns_head helper Guixin Liu
2023-12-28 1:48 ` Liu Song
2023-12-28 6:17 ` Christoph Hellwig [this message]
2024-01-01 9:49 ` Sagi Grimberg
2024-01-02 21:05 ` Keith Busch
2024-01-03 16:18 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231228061716.GA12379@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=kanie@linux.alibaba.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox