public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: mengfanhui <mengfanhui@kylinos.cn>,
	kbusch@kernel.org, axboe@kernel.dk, hch@lst.de,
	linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme-multipath: fix bogus request queue reference put
Date: Wed, 17 Jan 2024 15:39:52 +0100	[thread overview]
Message-ID: <20240117143952.GA27918@lst.de> (raw)
In-Reply-To: <b926d754-130d-424e-b099-001e14badc50@grimberg.me>

On Wed, Jan 17, 2024 at 04:04:12PM +0200, Sagi Grimberg wrote:
> How did you see this? disk->queue is allocated in blk_alloc_disk called
> in nvme_mpath_alloc_disk... I don't understand how you saw the same
> dereference that was addressed by this commit.

This looks like a backport of an old patch of yours to a geriatric
kernel to me..


  reply	other threads:[~2024-01-17 14:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-17  6:50 [PATCH] nvme-multipath: fix bogus request queue reference put mengfanhui
2024-01-17 14:04 ` Sagi Grimberg
2024-01-17 14:39   ` Christoph Hellwig [this message]
2024-03-14  6:13     ` mengfanhui
2024-03-17  7:33       ` Sagi Grimberg
2024-03-20  2:03         ` mengfanhui
2024-03-20  9:06           ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240117143952.GA27918@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=kbusch@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=mengfanhui@kylinos.cn \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox