Re: [PATCH V8 1/1] nvme: allow passthru cmd error logging

Christoph Hellwig
2024-01-11T07:04:59Z

On Wed, Jan 10, 2024 at 04:08:55PM -0800, Alan Adamson wrote:
> +int nvme_sysfs_add_passthru_err_log(struct device *dev)
> +{
> + return sysfs_create_group(&dev->kobj, &nvme_log_attr_group);
> +}
> +
> +void nvme_sysfs_remove_passthru_err_log(struct device *dev)
> +{
> + sysfs_remove_group(&dev->kobj, &nvme_log_attr_group);
> +}

Isn't the normal sysfs convention to have an is_visible method
instead of dynamically adding/removing groups?

Otherwise this looks good to me.