From: Guixin Liu <kanie@linux.alibaba.com>
To: kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me
Cc: linux-nvme@lists.infradead.org
Subject: [PATCH 2/3] nvme: parse dsm command detailly when tracing
Date: Mon, 29 Jan 2024 16:22:55 +0800 [thread overview]
Message-ID: <20240129082256.63239-3-kanie@linux.alibaba.com> (raw)
In-Reply-To: <20240129082256.63239-1-kanie@linux.alibaba.com>
Add detailed parse of dsm command to make the trace log more
consistent and human-readable.
Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
---
drivers/nvme/host/trace.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/nvme/host/trace.c b/drivers/nvme/host/trace.c
index 95572c85b22a..b383d51c1a0c 100644
--- a/drivers/nvme/host/trace.c
+++ b/drivers/nvme/host/trace.c
@@ -153,10 +153,12 @@ static const char *nvme_trace_read_write(struct trace_seq *p, u8 *cdw10)
static const char *nvme_trace_dsm(struct trace_seq *p, u8 *cdw10)
{
const char *ret = trace_seq_buffer_ptr(p);
+ u8 nr = cdw10[0];
+ u8 idr = cdw10[4] & 0x1;
+ u8 idw = (cdw10[4] >> 1) & 0x1;
+ u8 ad = (cdw10[4] >> 2) & 0x1;
- trace_seq_printf(p, "nr=%u, attributes=%u",
- get_unaligned_le32(cdw10),
- get_unaligned_le32(cdw10 + 4));
+ trace_seq_printf(p, "nr=%u, idr=%u, idw=%u, ad=%u", nr, idr, idw, ad);
trace_seq_putc(p, 0);
return ret;
--
2.43.0
next prev parent reply other threads:[~2024-01-29 8:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 8:22 [PATCH 0/3] *** nvme: add some commands tracing *** Guixin Liu
2024-01-29 8:22 ` [PATCH 1/3] nvme: add tracing of reservation commands Guixin Liu
2024-01-29 8:22 ` Guixin Liu [this message]
2024-01-29 11:09 ` [PATCH 2/3] nvme: parse dsm command detailly when tracing Chaitanya Kulkarni
2024-01-30 3:51 ` Guixin Liu
2024-01-30 8:05 ` Chaitanya Kulkarni
2024-01-30 8:35 ` Guixin Liu
2024-01-31 17:36 ` Keith Busch
2024-01-29 8:22 ` [PATCH 3/3] nvme: parse format command's lbafu " Guixin Liu
2024-01-29 11:01 ` Chaitanya Kulkarni
2024-01-30 3:37 ` Guixin Liu
-- strict thread matches above, loose matches on Subject: below --
2024-01-30 11:34 [PATCH v2 0/3] *** nvme: add some commands tracing *** Guixin Liu
2024-01-30 11:34 ` [PATCH 2/3] nvme: parse dsm command detailly when tracing Guixin Liu
2024-01-30 11:35 ` Guixin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240129082256.63239-3-kanie@linux.alibaba.com \
--to=kanie@linux.alibaba.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox