From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1A78C48BC3 for ; Mon, 19 Feb 2024 19:17:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hP0JzOSxa8Ak34PkLlYrH+BW+BeCI1kfUuoJPW8HusA=; b=Vha05tzCdMMwg+MKgFiP8lBRRl Gq7LciyLZH1E+MVe6FQzYFzSoegA10BCSb1gioqqgfu4jg4WGHHczZM1PiBI6sceYXSGaR+NCWp2K lK05sCYHD3EDaVnAPgfBVXvNYgyY/I74ltBYrIyoj7z7jQETRaXWlBfOBXXopX42I41vfEK24Q8N/ WGDDd6pDPvNeAQyMTfXBRTUKqxkr7A24OwsJYodPQFyYd7CrYy0WRIst7SbITYKEd5CmQV+QuKV7Z Q8B7WzFW6X76+W9ddCoB8yQ/unTzYVmc6nGza+3azdsDzZwvYg9UxGIreBt3L3g6oLpZuY0sbl5g6 BNjDkT1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rc98p-0000000BrOI-1a9u; Mon, 19 Feb 2024 19:17:27 +0000 Received: from smtp-out1.suse.de ([2a07:de40:b251:101:10:150:64:1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rc98l-0000000BrMM-0gaP for linux-nvme@lists.infradead.org; Mon, 19 Feb 2024 19:17:25 +0000 Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 345AF21CDF; Mon, 19 Feb 2024 19:17:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708370239; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hP0JzOSxa8Ak34PkLlYrH+BW+BeCI1kfUuoJPW8HusA=; b=L+vMdNx52tHJkwchBcBa001qK+SZbtkZ0/HROkYFTpK0Mp6T669V9VwOkeXDQTpQ2fHujp itj6yObR2GSzdmVyzY6nN++Gzw11Xb9rJnuhobwQBRoOg7xeCeTWPpEjTMyFFVrVdH1zO/ QWJf0rogCt/jib7V0aowiiggrz/iFOo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708370239; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hP0JzOSxa8Ak34PkLlYrH+BW+BeCI1kfUuoJPW8HusA=; b=s7FAO35emUqsBT78ndugZlEtb/uTp91WcAJqAHeiXy2r8Or+q1xNYrwiD46+AOf7djzZ9L PZKkia9ha8+FKbAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708370239; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hP0JzOSxa8Ak34PkLlYrH+BW+BeCI1kfUuoJPW8HusA=; b=L+vMdNx52tHJkwchBcBa001qK+SZbtkZ0/HROkYFTpK0Mp6T669V9VwOkeXDQTpQ2fHujp itj6yObR2GSzdmVyzY6nN++Gzw11Xb9rJnuhobwQBRoOg7xeCeTWPpEjTMyFFVrVdH1zO/ QWJf0rogCt/jib7V0aowiiggrz/iFOo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708370239; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hP0JzOSxa8Ak34PkLlYrH+BW+BeCI1kfUuoJPW8HusA=; b=s7FAO35emUqsBT78ndugZlEtb/uTp91WcAJqAHeiXy2r8Or+q1xNYrwiD46+AOf7djzZ9L PZKkia9ha8+FKbAg== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 0B3F5139C6; Mon, 19 Feb 2024 19:17:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id ciGVAj+p02UMUgAAn2gu4w (envelope-from ); Mon, 19 Feb 2024 19:17:19 +0000 Date: Mon, 19 Feb 2024 20:16:34 +0100 From: David Sterba To: John Garry Cc: axboe@kernel.dk, kbusch@kernel.org, hch@lst.de, sagi@grimberg.me, jejb@linux.ibm.com, martin.petersen@oracle.com, djwong@kernel.org, viro@zeniv.linux.org.uk, brauner@kernel.org, dchinner@redhat.com, jack@suse.cz, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org, tytso@mit.edu, jbongio@google.com, linux-scsi@vger.kernel.org, ojaswin@linux.ibm.com, linux-aio@kvack.org, linux-btrfs@vger.kernel.org, io-uring@vger.kernel.org, nilay@linux.ibm.com, ritesh.list@gmail.com, Prasad Singamsetty Subject: Re: [PATCH v4 03/11] fs: Initial atomic write support Message-ID: <20240219191634.GY355@twin.jikos.cz> References: <20240219130109.341523-1-john.g.garry@oracle.com> <20240219130109.341523-4-john.g.garry@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240219130109.341523-4-john.g.garry@oracle.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) X-Spamd-Bar: / Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=L+vMdNx5; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=s7FAO35e X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-0.26 / 50.00]; HAS_REPLYTO(0.30)[dsterba@suse.cz]; RCVD_VIA_SMTP_AUTH(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:98:from]; TO_DN_SOME(0.00)[]; REPLYTO_ADDR_EQ_FROM(0.00)[]; R_RATELIMIT(0.00)[to_ip_from(RLpoxz4e4fx16srn3jiqdcgp9j)]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[suse.cz:+]; MX_GOOD(-0.01)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-0.55)[80.88%]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-1.00)[-1.000]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; RCPT_COUNT_TWELVE(0.00)[26]; DBL_BLOCKED_OPENRESOLVER(0.00)[oracle.com:email,suse.cz:dkim]; FUZZY_BLOCKED(0.00)[rspamd.com]; FREEMAIL_CC(0.00)[kernel.dk,kernel.org,lst.de,grimberg.me,linux.ibm.com,oracle.com,zeniv.linux.org.uk,redhat.com,suse.cz,vger.kernel.org,lists.infradead.org,mit.edu,google.com,kvack.org,gmail.com]; RCVD_TLS_ALL(0.00)[]; SUSPICIOUS_RECIPS(1.50)[] X-Rspamd-Queue-Id: 345AF21CDF X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240219_111723_371184_EB67A96E X-CRM114-Status: UNSURE ( 9.39 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: dsterba@suse.cz Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Mon, Feb 19, 2024 at 01:01:01PM +0000, John Garry wrote: > From: Prasad Singamsetty > --- a/include/uapi/linux/fs.h > +++ b/include/uapi/linux/fs.h > @@ -301,9 +301,12 @@ typedef int __bitwise __kernel_rwf_t; > /* per-IO O_APPEND */ > #define RWF_APPEND ((__force __kernel_rwf_t)0x00000010) > > +/* Atomic Write */ > +#define RWF_ATOMIC ((__force __kernel_rwf_t)0x00000040) Should this be 0x20 so it's the next bit after RWF_APPEND?