Re: [PATCH v2] nvme-fabrics: check max outstanding commands

Chaitanya Kulkarni
2024-02-28T05:34:54Z

On 2/27/24 18:37, Guixin Liu wrote:
> Maxcmd is mandatory for fabrics, check it early to identify the root
> cause instead of waiting for it to propagate to "sqsize" and "allocing
> queue".
>
> By the way, change nvme_check_ctrl_fabric_info() to
> nvmf_validate_identify_ctrl().
>
> Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
> ---
> Changes from v1 to v2:
> - Revert nvme_check_ctrl_fabric_info() function name change.
>

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck